Repository navigation
chore(tickets): Plan the rustqual gate and burn-down - #1246
Merged
Merged
Conversation
File the tickets that take the rustqual linter from a committed-count baseline to a gate that names each new finding, and from there to zero findings. A new internal `qual` crate compares findings by `(rule, file, symbol)` between the measured tree and its base, analysed in the same run. CI, `cargo_check` and an unattended burn-down loop all call it, so they give the same verdict and the same messages. Dropping the committed baseline removes the staleness described in T-0yb2pgw, and leaves `qual:allow` markers and `.config/rustqual/` edits as the only way to silence the gate, both of which the gate reports. The burn-down reuses the bug-hunt script, split into a generic loop harness and per-mission hooks. Each run fixes one rule on its own branch. The rule policy records two decisions already taken: IOSP is exempt, and `file_length` starts at 800. Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File the tickets that take the rustqual linter from a committed-count baseline to a gate that names each new finding, and from there to zero findings.
A new internal
qualcrate compares findings by(rule, file, symbol)between the measured tree and its base, analysed in the same run. CI,cargo_checkand an unattended burn-down loop all call it, so they give the same verdict and the same messages. Dropping the committed baseline removes the staleness described in T-0yb2pgw, and leavesqual:allowmarkers and.config/rustqual/edits as the only way to silence the gate, both of which the gate reports.The burn-down reuses the bug-hunt script, split into a generic loop harness and per-mission hooks. Each run fixes one rule on its own branch. The rule policy records two decisions already taken: IOSP is exempt, and
file_lengthstarts at 800.