Repository navigation
Conversation
A conversation holding a chat response variant this build does not know can no longer fail to load. `ChatResponse` is untagged, so a new variant is stored under the known `chat_response` type with a new content key, and the unknown-event preservation from #778 never saw it: the entry failed to deserialize and the workspace skipped the whole conversation. A `chat_response` holding none of the known content keys (`message`, `reasoning`, `data`) is now kept verbatim and hidden, like an unknown event type, and written back unchanged on save. A known key with a malformed value still fails the load. This ships ahead of the assistant commentary work, which adds a `commentary` chat response, so builds have time to pick it up before anything writes one. Signed-off-by: Jean Mertz <git@jeanmertz.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A conversation holding a chat response variant this build does not
know can no longer fail to load.
ChatResponseis untagged, so a newvariant is stored under the known
chat_responsetype with a newcontent key, and the unknown-event preservation from #778 never saw
it: the entry failed to deserialize and the workspace skipped the
whole conversation.
A
chat_responseholding none of the known content keys (message,reasoning,data) is now kept verbatim and hidden, like an unknownevent type, and written back unchanged on save. A known key with a
malformed value still fails the load.
This ships ahead of the assistant commentary work, which adds a
commentarychat response, so builds have time to pick it up beforeanything writes one.
Signed-off-by: Jean Mertz git@jeanmertz.com