Repository navigation
Conversation
`jp c show` on a 9,138-event conversation spent 2.4 seconds on its main thread building the details block, against 76 ms to load the conversation. Counting turns through `iter_turns()` and reading the last timestamp through `last()` each resolved and cloned the full `PartialAppConfig` for every event in the stream. The command now uses `turn_count()` and `last_turn_event()`, which read event content only, and finishes in about 90 ms of main-thread work. The confirmation prompt's details block used the same two calls and gets the same fix. `ConversationStream::last()` itself walked the stream forward and cloned the config at every event to return the final one. It now steps back from the end and folds the config deltas once, returning the same event and config. `pop()` and `Extend` call it and benefit too. Signed-off-by: Jean Mertz <git@jeanmertz.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jp c showon a 9,138-event conversation spent 2.4 seconds on itsmain thread building the details block, against 76 ms to load the
conversation. Counting turns through
iter_turns()and reading thelast timestamp through
last()each resolved and cloned the fullPartialAppConfigfor every event in the stream. The command now usesturn_count()andlast_turn_event(), which read event content only,and finishes in about 90 ms of main-thread work. The confirmation
prompt's details block used the same two calls and gets the same fix.
ConversationStream::last()itself walked the stream forward andcloned the config at every event to return the final one. It now steps
back from the end and folds the config deltas once, returning the same
event and config.
pop()andExtendcall it and benefit too.Signed-off-by: Jean Mertz git@jeanmertz.com