Skip to content

Force synchronous ISYS suspend on close - #1

Closed
deep0294 with Copilot wants to merge 2 commits into
mainfrom
copilot/deep0294-change-pm-runtime-behavior
Closed

deep0294 with Copilot wants to merge 2 commits into
mainfrom
copilot/deep0294-change-pm-runtime-behavior

Conversation

Copilot AI commented Sep 16, 2026 •

Copy link
Copy Markdown

The ISYS video close path currently drops the runtime PM reference through the autosuspend path, which can leave the IS island short of a full power-cycle after an unclean STREAM_FLUSH / STREAM_CLOSE. This updates close handling to synchronously suspend on every final close so S2B/B2O return to POR state.

  • Close-path PM runtime behavior

    • Replace the final-close pm_runtime_put() in ipu7_isys_fw_close() with pm_runtime_put_sync_suspend().
    • This makes the close path force the suspend transition immediately instead of deferring through autosuspend.
  • Preserved rationale at callsite

    • Keep the close-path comment describing why every close should force an immediate IS island power-cycle, even when firmware close/flush completion is not clean.
  • Change scope

    • Limited to the single ISYS video close-path behavior change in drivers/media/pci/intel/ipu7/ipu7-isys-video.c.
/*
 * Force an immediate synchronous power-cycle of the IS island on
 * every close, ignoring autosuspend, so S2B/B2O return to POR state
 * even if STREAM_FLUSH/STREAM_CLOSE did not complete cleanly.
 */
pm_runtime_put_sync_suspend(&isys->adev->auxdev.dev);

Co-authored-by: deep0294 <154404789+deep0294@users.noreply.github.com>
Copilot AI changed the title [WIP] Update ISYS video close path for PM runtime behavior Force synchronous ISYS suspend on close Sep 16, 2026
Copilot AI requested a review from deep0294 September 16, 2026 08:17
@deep0294 deep0294 closed this Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants