Skip to content

fix: raise when non-bool passed to DisjointIntervalSequence.dna() #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SophiaPerzan-DG wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: raise when non-bool passed to DisjointIntervalSequence.dna() #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions genome_kit/diseq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1046,6 +1046,10 @@ def dna(self, allow_outside_coord: bool = True) -> str:
If the segment extends past the coord intervals and
``allow_outside_coord`` is False.
"""
if type(allow_outside_coord) is not bool:
raise TypeError(
f"allow_outside_coord must be a bool, got {type(allow_outside_coord).__name__}"
)
if self._start == self._end:
return ""

Expand Down
7 changes: 7 additions & 0 deletions tests/test_diseq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2663,6 +2663,13 @@ def test_off_coord_strand_minus_coord_multi_interval(self):
)
self.assertEqual(dis.dna(), expected)

def test_passing_non_bool_raises(self):
ivs = _make_intervals([("chr1", "+", 100, 200)])
dis = DisjointIntervalSequence(ivs, on_coordinate_strand=False, start=0, end=50)
dis2 = dis.cut(10, 20)
with self.assertRaises(TypeError):
dis.dna(dis2)


if __name__ == "__main__":
unittest.main()
Loading