Skip to content

[Deepin-Kernel-SIG] [linux 7.2.y] deepin: x86: enable rcu nocb cpu default all - #2160

Merged
opsiff merged 1 commit into
deepin-community:linux-7.2.yfrom
opsiff:linux-7.2.y-2026-09-17-lazy-rcu
Sep 17, 2026
Merged

opsiff merged 1 commit into
deepin-community:linux-7.2.yfrom
opsiff:linux-7.2.y-2026-09-17-lazy-rcu

Conversation

@opsiff

@opsiff opsiff commented Sep 17, 2026

Copy link
Copy Markdown
Member

The rcu lazy callbacks enabled by "deepin: x86: enable rcu lazy by default" take effect only on rcu_nocbs CPUs, that is, on the CPUs whose callbacks have been offloaded, so they cover no CPU unless the rcu_nocbs=all boot cmdline is passed. Enable
CONFIG_RCU_NOCB_CPU_DEFAULT_ALL to offload the callbacks of all CPUs by default, so that rcu lazy works with the default boot cmdline, and the rcu_nocbs boot parameter still takes precedence when specified.

Summary by Sourcery

Enhancements:

  • Enable RCU callback offloading for all CPUs by default in the Deepin x86 desktop configuration so RCU lazy callbacks are effective without additional boot parameters while preserving boot-time overrides.

The rcu lazy callbacks enabled by "deepin: x86: enable rcu lazy by
default" take effect only on rcu_nocbs CPUs, that is, on the CPUs
whose callbacks have been offloaded, so they cover no CPU unless the
rcu_nocbs=all boot cmdline is passed.  Enable
CONFIG_RCU_NOCB_CPU_DEFAULT_ALL to offload the callbacks of all CPUs
by default, so that rcu lazy works with the default boot cmdline, and
the rcu_nocbs boot parameter still takes precedence when specified.

Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
@sourcery-ai

sourcery-ai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR updates the Deepin x86 desktop defconfig to offload RCU callbacks on all CPUs by default, allowing the previously enabled RCU lazy-callback behavior to work with the default boot command line while retaining boot-time parameter control.

File-Level Changes

Change Details Files
Enable RCU callback offloading for all CPUs by default in the Deepin x86 desktop kernel configuration.
  • Add CONFIG_RCU_NOCB_CPU_DEFAULT_ALL to the desktop defconfig.
  • Preserve the existing rcu_nocbs boot-parameter override behavior.
  • Ensure RCU lazy callbacks are effective without requiring rcu_nocbs=all at boot.
arch/x86/configs/deepin_x86_desktop_defconfig

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@opsiff
opsiff merged commit 8ffc6ff into deepin-community:linux-7.2.y Sep 17, 2026
7 of 8 checks passed

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants