docs: adding docs for BedrockRetriever - #12475
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| @@ -0,0 +1,129 @@ | |||
| --- | |||
| title: "BedrockKnowledgeBaseRetriever" | |||
There was a problem hiding this comment.
I thought part of the issue was renaming the component?
There was a problem hiding this comment.
check here: https://github.com/deepset-ai/haystack-private/issues/550
wrong name: BedrockKnowledgeBaseRetriever instead of AmazonBedrockKnowledgeBaseRetriever
There was a problem hiding this comment.
Right, so are we planning to rename it to AmazonBedrockKnowledgeBaseRetriever?
There was a problem hiding this comment.
It was AmazonBedrockKnowledgeBaseRetriever before Stefano asked to rename it to BedrockKnowledgeBaseRetriever
There was a problem hiding this comment.
Okay, I misunderstood I took the original comment
wrong name: BedrockKnowledgeBaseRetriever instead of AmazonBedrockKnowledgeBaseRetriever
as saying that we would prefer AmazonBedrockKnowledgeBaseRetriever but if you talked with Stefano, all good!
There was a problem hiding this comment.
Shall I revert it?
There was a problem hiding this comment.
wait I mixed this up, it was BedrockKnowledgeBaseRetriever before, what mess, sorry
There was a problem hiding this comment.
Could you point me to the PR where you changed it from AmazonBedrockKnowledgeBaseRetriever to BedrockKnowledgeBaseRetriever?
There was a problem hiding this comment.
Original: deepset-ai/haystack-core-integrations#3842
I've opened another one to correct this: deepset-ai/haystack-core-integrations#3859
|
We should also copy these docs into the 3.1 versioned docs right? I also think we are missing an update to the sidebars.js file |
|
I've added the missing parts - thanks for the extra look @sjrl 👍🏽 |
This branch was successfully deployed
2 participants
Proposed Changes: