fix(converters): preserve literal NA strings in XLSXToDocument (#12945) - #13044
Open
HarshitR2004 wants to merge 2 commits into
Open
HarshitR2004 wants to merge 2 commits into
HarshitR2004 wants to merge 2 commits into
Conversation
HarshitR2004
requested review from
bogdankostic
and removed request for
a team
September 30, 2026 17:50
Contributor
|
@HarshitR2004 is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Hi @HarshitR2004, thanks for your interest in contributing to Haystack! 🙏 This is an automated message to help us keep the review queue healthy. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
keep_default_na=Falseandna_values=[""]inXLSXToDocument._extract_tables().pandas.read_excelfrom coercing literal string cells like"NA","N/A","NaN", or"null"into missing values and converting them to empty cells.read_excel_kwargs.read_excel_kwargsdocstring to reflect the default behavior.How did you test it?
test_run_preserves_literal_na_strings: verifies literal"NA"and"N/A"are preserved in CSV and Markdown tables while empty cells remain blank.test_run_keep_default_na_override: verifies passingread_excel_kwargs={"keep_default_na": True}allows opting back into pandas' default NA parsing.hatch -e test run pytest test/components/converters/test_xlsx_to_document.py(32 passed).mypy) and linting (ruff).Notes for the reviewer
na_values=[""]alongsidekeep_default_na=Falseensures unpopulated cells from openpyxl are still identified as missing values by pandas, so Markdownmissingvaland CSV formatting remain consistent.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.