Conversation
Contributor
|
@Harbor404 is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Hi @Harbor404, thanks for your interest in contributing to Haystack! 🙏 ⛔ First-time contributors can have at most 1 open pull request in this repository until it has been approved, so this PR was closed automatically. Your open pull request #13059 is unaffected. Once it has been approved by a maintainer, you are welcome to open more PRs. Feel free to reopen this one at that point. See the contributing guidelines for details. This is an automated message to help us keep the review queue healthy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
PPTXToDocumentonly iterated overparagraph.runswhen formatting links. This dropped<a:br/>soft line breaks because they are siblings of runs in the paragraph XML, somarkdownandplainoutput concatenated text across the break.The converter now walks the paragraph's content children in document order, preserving soft line breaks while still applying hyperlink formatting to runs. The default
nonebehavior is unchanged.PPTXToDocument._process_paragraph()to preserve soft line breaks formarkdownandplainlink formats.How did you test it?
hatch run test:unit test/components/converters/test_pptx_to_document.py -q --no-cov -k 'soft_line_break_preserved' --tb=short2 failed, 11 deselectedhatch run test:unit test/components/converters/test_pptx_to_document.py -q --no-cov --tb=short13 passedhatch run test:types haystack/components/converters/pptx.pySuccess: no issues found in 1 source filehatch run fmt-check haystack/components/converters/pptx.py test/components/converters/test_pptx_to_document.pyNotes for the reviewer
This PR is a draft because the repository currently allows only one non-draft PR per community contributor, and #13059 is already open. It can be marked ready for review once that PR is merged or closed.
This PR was fully generated with an AI assistant. I have reviewed the changes and run the relevant tests.
Checklist