Conversation
Contributor
|
@Afloat16 is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Resuming an in-memory
PipelineSnapshotcurrently uses its saved visit-count dictionary as the live execution counter. A completed or partially failed resume therefore rewrites the original checkpoint. Reusing it can incorrectly raisePipelineMaxComponentRuns.Copy the integer visit counters when resuming. Add regressions for repeated replay, retry after a downstream failure, and stepping through breakpoints without changing an earlier snapshot. Include a release note and recovery-guide clarification.
How did you test it?
On Linux with Python 3.12, using the repository's Hatch environments:
hatch run test:unit test/core/pipeline test/dataclasses/test_breakpoints.py -q: 447 passed, 155 integration cases deselected.hatch run test:types: no issues in 551 source files.hatch run fmton changed Python files, pre-commit hooks on all changed files, andgit diff --check: passed.Notes for the reviewer
The saved counters contain integers, so a shallow dictionary copy isolates resumed execution without copying component resources. Other unit modules and live integration tests were not run locally.
This PR was fully generated with an AI assistant. The change was reviewed and the validation above was run locally.
Checklist