Reject negative ignore_rows and ignore_columns in CSVDocumentCleaner - #13088
Open
Premvkmishra wants to merge 1 commit into
Open
Premvkmishra wants to merge 1 commit into
Premvkmishra wants to merge 1 commit into
Conversation
Premvkmishra
requested review from
julian-risch
and removed request for
a team
October 2, 2026 14:36
Contributor
|
@Premvkmishra is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
In
CSVDocumentCleaner.__init__, negative values forignore_rowsorignore_columnswere stored unvalidated. In_clean_df, pandasiloc[ignore_rows:, ignore_columns:]treated negative integers as offsets from the end of the DataFrame, leading to silent data loss without restoring ignored sections.CSVDocumentCleaner.__init__to raise aValueErrorifignore_rows < 0orignore_columns < 0, matching the style ofCSVDocumentSplitterandDocumentSplitter.:raises ValueError:entry in the component__init__docstring and updated parameter descriptions indocs-website/docs/pipeline-components/preprocessors/csvdocumentcleaner.mdx.renorelease note withfixesandupgradesections.How did you test it?
test_negative_ignore_rows_raises,test_negative_ignore_columns_raises, andtest_negative_ignore_values_raise_from_dict) intest/components/preprocessors/test_csv_document_cleaner.py.hatch run test:unit test/components/preprocessors/test_csv_document_cleaner.py(24 passed).hatch run test:types(mypy) andhatch run fmt(ruff).Notes for the reviewer
__init__before attribute assignment.0) and positive values behave unchanged.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.