Skip to content

fix: preserve dict subclass types in _deepcopy_with_exceptions #13097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Jah-yee wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −2
Draft

fix: preserve dict subclass types in _deepcopy_with_exceptions #13097

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions haystack/core/pipeline/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import heapq
from collections.abc import Callable
from copy import deepcopy
import copy
from functools import wraps
from itertools import count
from typing import Any
Expand Down Expand Up @@ -42,7 +42,16 @@ def _deepcopy_with_exceptions(obj: Any) -> Any:
return type(obj)(_deepcopy_with_exceptions(v) for v in obj)

if isinstance(obj, dict):
return {k: _deepcopy_with_exceptions(v) for k, v in obj.items()}
if type(obj) is dict:
return {k: _deepcopy_with_exceptions(v) for k, v in obj.items()}
try:
new = copy.copy(obj)
new.clear()
for k, v in obj.items():
new[k] = _deepcopy_with_exceptions(v)
return new
except Exception:
return {k: _deepcopy_with_exceptions(v) for k, v in obj.items()}

# Components and Tools often contain objects that we do not want to deepcopy or are not deepcopyable
# (e.g. models, clients, etc.). In this case we return the object as-is.
Expand Down