Conversation
Contributor
|
@carey-bk is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
OpenAIChatGeneratordropsreasoning/reasoning_contentfrom OpenAI-compatible providers (streaming and non-streaming) #13100Proposed Changes
Preserve non-empty string
reasoning/reasoning_contentresponse extras in the existingChatMessage.reasoningandStreamingChunk.reasoningfields. Preferreasoning, fall back toreasoning_content, and ignore empty or non-string values.Split mixed reasoning/text/tool deltas because a
StreamingChunkpermits only one payload type. Signal finish/usage on the last derived chunk. Once reasoning appears, track content-block indices separately from provider tool indices:ToolCallDelta.indexstays unchanged so argument reconstruction and final tool ordering remain stable, including sparse or out-of-order indices. Without reasoning, preserve the existing chunk indices and start markers.Update the docstring, component docs, and release note. No schema, dependency-bound, outgoing reasoning-replay, or Responses API changes.
How did you test it?
Offline HTTP JSON/SSE fixtures exercise real SDK parsing and public sync/async generator calls, with network sockets blocked.
87dba65f: 54 failed, 34 passed. All 22 ordinary-stream compatibility cases also pass on that baseline.yaml.py:40,test_device.py:60,document_splitter.py:276).These checks used focused Hatch environments. Live providers, the full unit suite, and the full docs build were not run.
Notes for the reviewer
Please review whether these non-standard fields belong in the generic generator or provider-specific integrations, given the historical discussion in #8776. A provider delta may now produce multiple callbacks when reasoning is present. #13079 addresses the separate Responses API path.
The implementation and tests were generated with AI assistance; the assistant performed the local validation above. Personal contributor attestations are left unchecked for human review.
Checklist