Skip to content

Fixed bug in alpha handling in arc links - #496

Merged
lldelisle merged 7 commits into
deeptools:developfrom
MCPahl:bugfix-links-alpha
Sep 2, 2026
Merged

Fixed bug in alpha handling in arc links#496
lldelisle merged 7 commits into
deeptools:developfrom
MCPahl:bugfix-links-alpha

Conversation

@MCPahl

@MCPahl MCPahl commented Aug 14, 2026

Copy link
Copy Markdown

Thanks for developing and maintaining this tool! I noticed a bug for handling alpha transparency to Matplotlib for link plots.

@lldelisle
lldelisle changed the base branch from master to develop September 2, 2026 05:34
@lldelisle

lldelisle commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Hi @MCPahl ,
Thank you so much for finding and fixing the bug and providing a high quality test. I changed the target to develop, I merged the develop commits and I added a new plot in the test folder with a changed alpha. I also changed the default value of alpha to 1 to keep the same behavior as before the bug fix.

@lldelisle

Copy link
Copy Markdown
Collaborator

@bgruening would you mind to review this one also?
@MCPahl noticed that the links track as a parameter alpha that was not used. In the help it was written that the default was 0.8 while the plotted alpha was 1. @MCPahl fixed the bug and I changed the default value from 0.8 to 1 to fit with the passed behaviour.

Comment thread test_locally.sh
coverage-badge -f -o docs/coverage.svg
micromamba deactivate

## Set environment to test lowMatplotlib

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always found that file a bit scary :)

But thanks for adding your case here as well.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more a working file for me to be able to find back how to test locally and keep trace of how I generated the figures...

@lldelisle
lldelisle merged commit 41db458 into deeptools:develop Sep 2, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants