Repository navigation
fix(web): bound stale portal signing keys and serialize JWKS refreshes - #1005
Open
defangdevs wants to merge 1 commit into
Open
defangdevs wants to merge 1 commit into
defangdevs wants to merge 1 commit into
Conversation
#634) Every return path of portal_jwks_keys now enforces JWKS_MAX_STALE (two hours since the last successful fetch), including the refresh cooldown and failed-fetch paths. The refresh attempt is reserved under a file lock before the network call, so concurrent requests cause at most one fetch. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RVYuG58Xp5uVuw6PdS6GHW
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 27 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #634.
Symptom: with JWKS fetches failing, cached keys were trusted forever (a year-old set was returned), and six concurrent requests caused six fetches.
portal_jwks_keysdrops keys older thanJWKS_MAX_STALE(2h = TTL + 1h grace) on every return path: cooldown, failed fetch and fresh.attemptedis written before the network call, so concurrent requests fetch at most once.docs/portal-handoff.mdstates the two-hour bound.portal-jwkscheck (tests/test-portal-jwks.py): expired keys rejected on failed fetch and during cooldown, grace still served, bound survives repeated failures, six threads -> one fetch.Checks run (aarch64): portal-jwks, module-generated-up-to-date, golden-snapshot. Regenerated
modules/agent-box.nixandtests/golden/.🤖 Generated with Claude Code