Skip to content

fix: add proxy configuration selector - #3470

Open
nbmaiti wants to merge 1 commit into
mainfrom
proxy_select_lebel
Open

nbmaiti wants to merge 1 commit into
mainfrom
proxy_select_lebel

Conversation

@nbmaiti

@nbmaiti nbmaiti commented Jul 27, 2026 •

Copy link
Copy Markdown

Description

Improves proxy configuration selector UX by converting from autocomplete input to mat-select dropdown component.

Changes

  • UI: Replace autocomplete input with mat-select dropdown for cleaner proxy selection
  • Method: Updated selectProxyProfile() to accept string parameter from mat-select selectionChange event
  • Reset: Use .reset() instead of .patchValue('') for proper form control clearing
  • Data Source: Use direct ProxyConfigurations() array instead of filtered async observable
  • Tests: Updated all test cases to work with string parameters and new reset behavior

Why

  • Better UX: dropdown vs free-text input for predefined options
  • Cleaner API: direct string parameter instead of event object wrapping
  • Proper form handling: .reset() clears both value and validation state

Testing

  • ✅ Unit tests updated and passing
  • ✅ Linting: all files pass ESLint
  • ✅ Formatting: prettier compliant

Files Changed

  • profile-detail.component.html (19 insertions, 45 deletions)
  • profile-detail.component.ts
  • profile-detail.component.spec.ts

This comment was marked as outdated.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread src/app/profiles/profile-detail/profile-detail.component.html Outdated
Comment thread src/app/profiles/profile-detail/profile-detail.component.html Outdated
Comment thread src/app/profiles/profile-detail/profile-detail.component.spec.ts Outdated
@nbmaiti
nbmaiti marked this pull request as draft September 29, 2026 07:45
@nbmaiti
nbmaiti force-pushed the proxy_select_lebel branch 5 times, most recently from 7a5b3a5 to 25e0cc1 Compare October 1, 2026 07:33
@nbmaiti
nbmaiti requested a balanced review from Copilot October 1, 2026 07:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread src/app/profiles/profile-detail/profile-detail.component.html
@nbmaiti
nbmaiti force-pushed the proxy_select_lebel branch 4 times, most recently from 527afef to a719ee4 Compare October 1, 2026 08:20
- Convert proxy selector from autocomplete input to mat-select dropdown
- Update selectProxyProfile() to accept string parameter from mat-select
- Use reset() instead of patchValue('') to properly clear selection
- Update tests to work with string parameters
- Use ProxyConfigurations() instead of filteredProxyList observable
@nbmaiti
nbmaiti force-pushed the proxy_select_lebel branch from a719ee4 to 6363e65 Compare October 1, 2026 08:36
@nbmaiti
nbmaiti requested a balanced review from Copilot October 1, 2026 08:43
@nbmaiti
nbmaiti marked this pull request as ready for review October 1, 2026 08:44
@nbmaiti
nbmaiti requested a review from sudhir-intc October 1, 2026 08:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Duplicate selection can leave the dropdown stuck and prevent re-adding a removed proxy.

Review effort: Balanced
Findings: 1 Medium severity · 2 Low severity

Open (3)
Resolved since last review (1)

Comment thread src/app/profiles/profile-detail/profile-detail.component.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants