Conversation
nbmaiti
force-pushed
the
proxy_select_lebel
branch
from
August 17, 2026 07:15
36af1ce to
74ed49a
Compare
nbmaiti
force-pushed
the
proxy_select_lebel
branch
from
September 3, 2026 18:57
74ed49a to
e05b97f
Compare
nbmaiti
force-pushed
the
proxy_select_lebel
branch
from
September 28, 2026 07:51
e05b97f to
757c1ef
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The dropdown does not reset correctly and can hide existing proxy associations.
Review effort: Balanced
Findings: 2
Open (5)
Show associated proxies when available configurations are missing · New Bind proxy select to reset its value after selection · New Add regression test for resetting and reselecting proxies · New The component now accepts a string inselectProxyProfile(used by the new<mat-select>), but…selectProxyProfilestill clearsproxyAutocomplete, but the template no longer binds…
nbmaiti
marked this pull request as draft
September 29, 2026 07:45
nbmaiti
force-pushed
the
proxy_select_lebel
branch
5 times, most recently
from
October 1, 2026 07:33
7a5b3a5 to
25e0cc1
Compare
nbmaiti
force-pushed
the
proxy_select_lebel
branch
4 times, most recently
from
October 1, 2026 08:20
527afef to
a719ee4
Compare
- Convert proxy selector from autocomplete input to mat-select dropdown
- Update selectProxyProfile() to accept string parameter from mat-select
- Use reset() instead of patchValue('') to properly clear selection
- Update tests to work with string parameters
- Use ProxyConfigurations() instead of filteredProxyList observable
nbmaiti
force-pushed
the
proxy_select_lebel
branch
from
October 1, 2026 08:36
a719ee4 to
6363e65
Compare
nbmaiti
marked this pull request as ready for review
October 1, 2026 08:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Improves proxy configuration selector UX by converting from autocomplete input to mat-select dropdown component.
Changes
mat-selectdropdown for cleaner proxy selectionselectProxyProfile()to accept string parameter from mat-selectselectionChangeevent.reset()instead of.patchValue('')for proper form control clearingProxyConfigurations()array instead of filtered async observableWhy
.reset()clears both value and validation stateTesting
Files Changed
profile-detail.component.html(19 insertions, 45 deletions)profile-detail.component.tsprofile-detail.component.spec.ts