Skip to content

fix localtime prototype - #30

Merged
justwheel merged 1 commit into
devshane:masterfrom
Jan200101:PR/localtime
Apr 16, 2026
Merged

fix localtime prototype#30
justwheel merged 1 commit into
devshane:masterfrom
Jan200101:PR/localtime

Conversation

@Jan200101

@Jan200101 Jan200101 commented Feb 19, 2026

Copy link
Copy Markdown
Collaborator

Ultrix 4.2 contains a correct prototype for localtime so this should not be an issue anymore.

justwheel
justwheel approved these changes Feb 21, 2026
View reviewed changes

@justwheel justwheel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a C developer, but given the context from the removed-comment, this change seems sensible to me, given the newer context of Ultrix 4.2…

@Jan200101

Jan200101 commented Feb 21, 2026

Copy link
Copy Markdown
Collaborator Author

An alternative solution would be removing the prototype at all, it should be pulled in by the header even on Ultrix and I am not aware why this used to be done.

@justwheel justwheel added the bug Something is broken or produces incorrect behavior label Feb 22, 2026
@justwheel justwheel added this to the v1.1.0 milestone Feb 22, 2026
@justwheel

justwheel commented Feb 22, 2026

Copy link
Copy Markdown
Collaborator

@jamesjer Would you be up for doing a peer review on this PR?

This was referenced Feb 22, 2026
Open
Closed
Closed
Closed
Closed
@justwheel justwheel linked an issue Feb 23, 2026 that may be closed by this pull request
Create git tag/release for Zork v1.1.0 #33
Closed
@justwheel justwheel mentioned this pull request Mar 5, 2026
Closed
@Jan200101 @justwheel
fix localtime prototype
30a117b 
Ultrix 4.2 contains a correct prototype for localtime so this should
not be an issue anymore.
@justwheel

justwheel commented Apr 16, 2026

Copy link
Copy Markdown
Collaborator

Enough time has passed here where I feel alright merging this to master. (It might also be time to update the default branch from master to main.) I do not want these pending PRs to sit forever, and it would be nice to fix up/eliminate some of our downstream patches in the Fedora package.

I am going to merge this one as a first step. In the meantime, it would be nice if PRs #31 and #32 could be rebased on latest changes in master. 😀

Merging! 🌊

@justwheel justwheel closed this Apr 16, 2026
@justwheel justwheel reopened this Apr 16, 2026
@justwheel
justwheel merged commit 30a117b into devshane:master Apr 16, 2026
This was referenced Apr 16, 2026
Merged
Merged
@justwheel justwheel added the compiler warning Discovered via compiler diagnostics label Apr 20, 2026
social4hyq pushed a commit to social4hyq/homebrew-core that referenced this pull request Sep 20, 2026
HarmonybrewBot HarmonybrewBot
!13226 merge bump-zork-1.1.0 into main
6f32412 
zork 1.1.0

Created-by: HarmonybrewBot
Commit-by: HarmonybrewBot
Merged-by: HarmonybrewBot
Description: Created by `brew bump`

---

Created with `brew bump-formula-pr`.<details>
  <summary>release notes</summary>
  <pre>## What's Changed
* Fix out-of-bounds array access in preposition vocabulary by @fuulish in devshane/zork#22
* Update local.c to include missing header unistd.h by @heademptyshivansh in devshane/zork#25
* 📝 README: Add install instructions, improve history, name maintainers by @justwheel in devshane/zork#35
* fix localtime prototype by @Jan200101 in devshane/zork#30
* add LDFLAGS to Makefile by @Jan200101 in devshane/zork#31
* 👷 ci: Add GitHub Actions build and smoke test pipeline by @justwheel in devshane/zork#38
* 🔧 `.github`: Add issue form template by @justwheel in devshane/zork#42
* add preprocessor to use plain curses header, correct setupterm prototype by @Jan200101 in devshane/zork#32

## New Contributors
* @fuulish made their first contribution in devshane/zork#22
* @heademptyshivansh made their first contribution in devshane/zork#25

**Full Changelog**: https://github.com/devshane/zork/releases/tag/v1.1.0</pre>
  <p>View the full release notes at <a href="https://github.com/devshane/zork/releases/tag/v1.1.0">https://github.com/devshane/zork/releases/tag/v1.1.0</a>.</p>
</details>
<hr>

See merge request: Harmonybrew/homebrew-core!13226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justwheel justwheel justwheel approved these changes

Assignees

@devshane devshane

@justwheel justwheel

@Jan200101 Jan200101

Labels

bug Something is broken or produces incorrect behavior compiler warning Discovered via compiler diagnostics

Projects

None yet

Milestone

v1.1.0

Development

Successfully merging this pull request may close these issues.

Create git tag/release for Zork v1.1.0

3 participants

@Jan200101 @justwheel @devshane