Conversation
This was referenced Apr 20, 2026
Merged
This project has had no automated testing or CI for its entire history. As a code-preservation project, manual play-testing was the only way to verify changes didn't break the game. This commit adds a GitHub Actions pipeline that proves compilation succeeds and the game starts correctly on every push and pull request. The pipeline tests with both GCC and Clang via a build matrix, catching compiler-specific issues in parallel. The Makefile defaults to `-ltermcap` which is unavailable as a standalone library on the CI runner; the workflow overrides with `LIBS="-lncurses"` which provides termcap compatibility through `ncurses`. A smoke test pipes LOOK, QUIT, Y into the game and asserts the welcome banner, opening room description, and clean exit message all appear. This catches initialization failures, data file corruption, and command loop regressions without modifying any game source. Compilation caching via `ccache` keeps repeat builds fast. Each compiler gets its own cache keyed on source file content hashes, with prefix- based restore, so a single changed file still benefits from cached results for the other 32 compilation units. Concurrency controls cancel in-progress runs when new commits land on the same ref. No game source files are modified — the CI infrastructure is entirely additive and lives in `.github/`. Assisted-by: Claude Opus 4.6 (1M context) Signed-off-by: Justin Wheeler <jwheel@fedoraproject.org>
Jan200101
approved these changes
May 2, 2026
Jan200101
left a comment
Jan200101
left a comment
Collaborator
There was a problem hiding this comment.
looks good to me, caching may be a bit overkill because of how quick the compilation is.
Collaborator
Author
|
Thanks @Jan200101 for the review. I am going to go ahead and merge it, and rebase any other pending PRs that I can. Merging! 🌊 |
social4hyq
pushed a commit
to social4hyq/homebrew-core
that referenced
this pull request
Sep 20, 2026
zork 1.1.0 Created-by: HarmonybrewBot Commit-by: HarmonybrewBot Merged-by: HarmonybrewBot Description: Created by `brew bump` --- Created with `brew bump-formula-pr`.<details> <summary>release notes</summary> <pre>## What's Changed * Fix out-of-bounds array access in preposition vocabulary by @fuulish in devshane/zork#22 * Update local.c to include missing header unistd.h by @heademptyshivansh in devshane/zork#25 * 📝 README: Add install instructions, improve history, name maintainers by @justwheel in devshane/zork#35 * fix localtime prototype by @Jan200101 in devshane/zork#30 * add LDFLAGS to Makefile by @Jan200101 in devshane/zork#31 * 👷 ci: Add GitHub Actions build and smoke test pipeline by @justwheel in devshane/zork#38 * 🔧 `.github`: Add issue form template by @justwheel in devshane/zork#42 * add preprocessor to use plain curses header, correct setupterm prototype by @Jan200101 in devshane/zork#32 ## New Contributors * @fuulish made their first contribution in devshane/zork#22 * @heademptyshivansh made their first contribution in devshane/zork#25 **Full Changelog**: https://github.com/devshane/zork/releases/tag/v1.1.0</pre> <p>View the full release notes at <a href="https://github.com/devshane/zork/releases/tag/v1.1.0">https://github.com/devshane/zork/releases/tag/v1.1.0</a>.</p> </details> <hr> See merge request: Harmonybrew/homebrew-core!13226
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This project has had no automated testing or CI for its entire history. As a code-preservation project, manual play-testing was the only way to verify changes didn't break the game. This commit adds a GitHub Actions pipeline that proves compilation succeeds and the game starts correctly on every push and pull request.
The pipeline tests with both GCC and Clang via a build matrix, catching compiler-specific issues in parallel. The Makefile defaults to
-ltermcapwhich is unavailable as a standalone library on the CI runner; the workflow overrides withLIBS="-lncurses"which provides termcap compatibility throughncurses.A smoke test pipes LOOK, QUIT, Y into the game and asserts the welcome banner, opening room description, and clean exit message all appear. This catches initialization failures, data file corruption, and command loop regressions without modifying any game source.
Compilation caching via
ccachekeeps repeat builds fast. Each compiler gets its own cache keyed on source file content hashes, with prefix- based restore, so a single changed file still benefits from cached results for the other 32 compilation units. Concurrency controls cancel in-progress runs when new commits land on the same ref.No game source files are modified — the CI infrastructure is entirely additive and lives in
.github/.