Repository navigation
chore: fix new clippy lints, update lockfiles, extend dependabot - #35
Merged
Merged
Conversation
Rust 1.98 clippy flags needless_late_init in sonora-aec3 and chunks_exact_to_as_chunks in sonora-agc2 test helpers, which fails CI under -D warnings. Use if-expressions for the late inits (keeps the upstream branch structure) and slice::as_chunks (stable since 1.88, within MSRV 1.91). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H29DamSLugosGXJSz1e5Yx
Run cargo update for the workspace and the three excluded manifests (fuzz, sonora-sys, sonora-bench). All updates are semver-compatible; no manifest changes. Fixes two advisories in the dev-only lockfiles: - RUSTSEC-2026-0202: cxx 1.0.194 -> 1.0.202 (sonora-sys) - RUSTSEC-2026-0204: crossbeam-epoch 0.9.18 -> 0.9.21 (sonora-bench) Supersedes the closed Dependabot PRs #30-#33. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H29DamSLugosGXJSz1e5Yx
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
=======================================
Coverage 93.64% 93.64%
=======================================
Files 146 146
Lines 31132 31130 -2
Branches 31132 31130 -2
=======================================
- Hits 29154 29153 -1
+ Misses 1754 1753 -1
Partials 224 224
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
fuzz, sonora-sys, and sonora-bench are excluded from the workspace and carry their own Cargo.lock, so the root cargo entry never updated them. That is how RUSTSEC-2026-0202 (cxx) and RUSTSEC-2026-0204 (crossbeam-epoch) went unnoticed in the dev-only lockfiles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H29DamSLugosGXJSz1e5Yx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI on
mainfails under Rust 1.98, because newer Clippy lints error out under-D warnings. The same failure caused Dependabot PRs #30–#33 to fail. This PR fixes the lints, updates every lockfile in the repository, and extends Dependabot to the lockfiles it was missing.Commit 1: fix new clippy lints
needless_late_init(4 sites insonora-aec3):echo_audibility.rs,matched_filter_lag_aggregator.rs, and two inresidual_echo_estimator.rs. Each is now anifexpression. The upstream branch structure is unchanged, and the change does not affect behavior.chunks_exact_to_as_chunks(2 test helpers insonora-agc2/src/rnn_vad/): both now useslice::as_chunks::<4>(). It has been stable since Rust 1.88, which is within our 1.91 minimum.Commit 2: update lockfiles
Runs
cargo updatefor the workspace and the three excluded manifests. All updates are semver-compatible, and no manifest changes.Cargo.lockcrates/sonora-sys/Cargo.lockcxx1.0.194 → 1.0.202).crates/sonora-bench/Cargo.lockcrossbeam-epoch0.9.18 → 0.9.21, via criterion).fuzz/Cargo.lockBoth advisories affect only unpublished, dev-only crates.
Verification (local, aarch64-apple-darwin, rustc 1.98)
cargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo clippy -p sonora --all-targets --features examples -- -D warningscargo test --workspace: 760 passed, 0 failed, 0 ignoredcargo +1.91.1 check --workspace --all-targets(MSRV)RUSTDOCFLAGS=-D warnings cargo doc --workspace --no-depscargo deny check advisorieson all four lockfilescargo checkforsonora-bench+sonora-sys(against the local C++ install) andfuzzCommit 3: Dependabot coverage for the excluded manifests
.github/dependabot.ymlnow has weeklycargoentries for/fuzz,/crates/sonora-sys, and/crates/sonora-bench. These directories are excluded from the workspace and have their ownCargo.lock, so the root entry never updated them. That gap let both advisories above go unnoticed. The YAML parses, and each directory has its ownCargo.tomlandCargo.lock.🤖 Generated with Claude Code
https://claude.ai/code/session_01H29DamSLugosGXJSz1e5Yx