Skip to content

feat: openarm hardware support with dm_control - #3388

Open
TomCC7 wants to merge 13 commits into
cc/feat/openyam-driverfrom
krishna/feat/openarm-damiao
Open

feat: openarm hardware support with dm_control#3388
TomCC7 wants to merge 13 commits into
cc/feat/openyam-driverfrom
krishna/feat/openarm-damiao

Conversation

@TomCC7

@TomCC7 TomCC7 commented Aug 6, 2026

Copy link
Copy Markdown
Member

Reopens the OpenArm Damiao changes from #3351 after the intentional revert in #3387.

The original PR was merged and therefore cannot be reopened on GitHub. This replacement PR uses the same head branch and targets the same stacked base.

Please carry review context forward from #3351. The branch contains the hardware-validated follow-up fixes that landed before the original merge.

closes DIM-979

…ody adapter

Add OpenArmDamiaoAdapter: both v10 arms (2x DM8006, 2x DM4340, 3x DM4310,
send ids 0x01..0x07) and both grippers (DM4310 at 0x08) as one whole-body
device over two CAN buses (left=can1, right=can0), with gravity compensation
from the bimanual URDF (14 joints, validated order left1..7 then right1..7).

Rewrite the OpenArm hardware config on the OpenYAM pattern: one 16-joint
WHOLE_BODY component, mock/real selection via global_config.simulation,
hardware-measured MIT gains carried over from the legacy adapter, and
per-side planning models gaining an explicit coordinator->URDF joint name
mapping.

Blueprints: coordinator-openarm, openarm-planner-coordinator,
keyboard-teleop-openarm and keyboard-teleop-openarm-planner. The keyboard
jogs the left arm while the right arm's twist task holds pose; a single
servo task drives both grippers, enabled by a new
KeyboardTeleopConfig.gripper_joint_names field. The e2e planning-groups
test moves to openarm-planner-coordinator since the harness's --simulation
flag now selects the in-memory adapter.
The hand-rolled Damiao CAN driver and manipulator-protocol adapter are fully
replaced by OpenArmDamiaoAdapter on the whole-body path, which also wires the
previously unimplemented grippers. Drop the legacy CAN bring-up scripts
(superseded by 'dimos can setup') and the openarm manipulator registry entry.
DM8009 shoulders (DM8006 was a legacy typo), MotorSpecs as plain lists,
keyboard teleop module restored to upstream with gripper bindings deferred
to a follow-up PR, and dual-arm planning switched to a single bimanual
robot model with left_manipulator and right_manipulator groups fed by a
hand-written SRDF, since generated SRDFs cannot express cross-robot
collision exclusions. Planner blueprint verified against the in-memory
adapter in simulation.
Replace the stale v1.0 data package with URDFs generated from the official
OpenArm v2.0 preset pipeline (enactic/openarm_description @ 6c7b720f1ba,
default_bimanual plus per-side pinch gripper presets). Pinch gripper finger
joints are fixed in the generated models so each arm exposes exactly its
seven driven joints while keeping gripper geometry and mass; mesh URIs stay
package relative and ros2_control blocks are dropped. The package ships
v2.0 meshes, the three URDFs, and a PROVENANCE file, and shrinks from 70 MB
to 8 MB.

The v2.0 generator collapses link7, so planning tips move to
openarm_{side}_ee_base_link and the SRDF now disables the sibling finger
pair per hand. Joint naming is unchanged from v1.0, so the adapter topology
and gravity joint order carry over. Verified with pinocchio (14 and 7 DOF
models, finite gravity) and a planner blueprint run in simulation.
RoboPlan generated composite planning groups only for selections spanning
two or more robots, so a bimanual robot modeled as one URDF with two
planning groups could not plan both arms in a single request. Drop the
robot-count restriction; the joint-disjointness requirement and the
composite group cap still apply, and overlapping selections are already
rejected at the selection layer. Verified in process on the OpenArm 2.0
bimanual model: left, right, and combined fourteen-joint plans all
succeed.
Converted OBJ files were named by stem only, so a robot whose visual and
collision meshes share a stem (OpenArm v2.0 uses visual/link3.dae and
collision/link3.stl) had the collision conversion overwrite the visual
one, and viewers rendered collision geometry in visual mode. Suffix the
converted name with a hash of the source path and pin the behavior with
tests.
Regenerate the v2.0 URDFs with emit_grasp_frame enabled and move the
planning group tip links from the ee flange to openarm_{side}_grasp_frame,
matching the OpenYAM gripper_tip convention. Model DOF, joint order, and
gravity behavior are unchanged; planning verified for left, right, and
combined requests.
The optimistic target ghost rebuilt its per-robot joint values from the
current state for every selected group, so with two planning groups on
one robot the group processed last discarded the other group's target
and the ghost only ever showed one arm's goal. Seed the merge once per
robot and overlay each group's target into the same values.
The pinch gripper finger joints are fixed in the generated models and
their collision meshes do not intersect at the fixed pose, so the manual
exclusions were dead weight. Verified left, right, and combined plans
still succeed without the file.
Gripper opening calibrates during activation, and reading it earlier
raises, so a connected but not activated whole-body adapter failed the
entire state read and read-only bring-up sessions (connect without
enable) streamed nothing. Report placeholder gripper states until the
adapter is active; arms stream immediately and real openings appear
after activation. Found on OpenArm hardware during the read-only phase.
Damiao feedback only updates when the bus is ticked, which the write
path does once per control cycle while the adapter is active. A
connected but not activated adapter never ticked, so read-only sessions
streamed the connect-time snapshot forever. Refresh from the read path
whenever the adapter is inactive; the active path is unchanged and
still ticks exactly once per cycle.
@greptile-apps

greptile-apps Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR restores OpenArm v2.0 as a synchronized bimanual Damiao whole-body device and updates its planning, visualization, blueprint, testing, asset, and documentation support.

  • Replaces the per-arm OpenArm driver with the shared Damiao whole-body adapter architecture.
  • Models both arms and grippers as one 16-joint hardware component with a 14-joint bimanual planning model.
  • Updates simulation-aware blueprints, mesh conversion, Viser behavior, tests, LFS assets, and operator documentation.

Confidence Score: 5/5

The PR appears safe to merge because no blocking failure remains in the eligible follow-up review scope.

No blocking failure remains.

Important Files Changed

Filename Overview
dimos/hardware/whole_body/openarm_damiao/adapter.py Defines the OpenArm v2.0 motor topology, bus defaults, joint ordering, grippers, and gravity model on the generic Damiao adapter.
dimos/hardware/whole_body/damiao/adapter.py Keeps arm feedback moving during inactive read-only sessions and supplies pre-activation gripper placeholders.
dimos/robot/manipulators/openarm/config.py Selects simulated or physical whole-body hardware and defines the synchronized hardware and bimanual planning-model mappings.
dimos/robot/manipulators/openarm/blueprints/teleop.py Rebuilds keyboard teleoperation and planner composition around per-arm EEF tasks and a shared bimanual trajectory task.
dimos/manipulation/planning/utils/mesh_utils.py Disambiguates converted mesh filenames derived from source paths.
dimos/manipulation/planning/world/roboplan_model.py Updates composed planning-model behavior for the restored bimanual OpenArm model.
dimos/manipulation/visualization/viser/gui.py Updates Viser integration for the changed multi-group OpenArm planning and visualization flow.
dimos/robot/all_blueprints.py Regenerates the blueprint registry for the consolidated OpenArm blueprint set.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
    CLI[OpenArm blueprint] --> CFG[Simulation-aware hardware config]
    CFG -->|Simulation| MOCK[Mock whole-body adapter]
    CFG -->|Hardware| OA[OpenArm Damiao adapter]
    OA --> DAMIAO[Generic Damiao whole-body lifecycle]
    DAMIAO --> LEFT[Left CAN bus and arm]
    DAMIAO --> RIGHT[Right CAN bus and arm]
    CFG --> COORD[Control coordinator]
    PLAN[Bimanual planning model] --> COORD
    COORD --> OA
    COORD --> MOCK
Loading

Reviews (2): Last reviewed commit: "Merge branch 'cc/feat/openyam-driver' in..." | Re-trigger Greptile

@TomCC7 TomCC7 changed the title Restore OpenArm Damiao support after revert feat: openarm hardware support with dm_control Aug 6, 2026
@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
4256 1 4255 69
View the top 1 failed test(s) by shortest run time
dimos.e2e_tests.test_manipulation_planning_groups::test_dual_arm_plans_and_dispatches_both_arms_through_control_coordinator
Stack Traces | 18.5s run time
dimos.protocol.rpc.rpc_utils.RemoteError: [Remote builtins.RuntimeError] Invalid goal configuration requested, cannot plan!

Remote traceback:
Traceback (most recent call last):
  File ".../protocol/rpc/pubsubrpc.py", line 280, in execute_and_respond
    response = f(*args[0], **args[1])
               ^^^^^^^^^^^^^^^^^^^^^^
  File ".../protocol/rpc/spec.py", line 116, in override_f
    return getattr(module, fname)(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../dimos/manipulation/manipulation_module.py", line 923, in plan_to_joint_targets
    return self.generate_plan_to_joint_targets(joint_targets) is not None
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../dimos/manipulation/manipulation_module.py", line 962, in generate_plan_to_joint_targets
    return self._plan_selected_path(group_ids, start, goal, planning_epoch)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../dimos/manipulation/manipulation_module.py", line 652, in _plan_selected_path
    result = self._planner.plan_selected_joint_path(
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../planning/planners/roboplan_planner.py", line 164, in plan_selected_joint_path
    return self._plan_group(
           ^^^^^^^^^^^^^^^^^
  File ".../planning/planners/roboplan_planner.py", line 552, in _plan_group
    result = self._run_native_rrt(
             ^^^^^^^^^^^^^^^^^^^^^
  File ".../planning/planners/roboplan_planner.py", line 597, in _run_native_rrt
    result = planner.plan(start, goal)
             ^^^^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: Invalid goal configuration requested, cannot plan!


The above exception was the direct cause of the following exception:

lcm_spy = <dimos.e2e_tests.lcm_spy.LcmSpy object at 0x76164c99fc50>
start_blueprint = <function start_blueprint.<locals>.set_name_and_start at 0x76163d582e80>

    def test_dual_arm_plans_and_dispatches_both_arms_through_control_coordinator(
        lcm_spy: LcmSpy,
        start_blueprint: Callable[..., DimosCliCall],
    ) -> None:
        """Plan one generated plan over both arms and dispatch through one trajectory task."""
        _start_openarm_mock_planner(start_blueprint, lcm_spy)
    
        client = RPCClient(None, ManipulationModule)
        coordinator_client = RPCClient(None, ControlCoordinator)
        try:
            info = _wait_for_robot_info(client, ROBOT_NAME)
            group_ids = _planning_group_ids(info)
    
            tasks = coordinator_client.list_tasks()
            assert tasks == [DEFAULT_TRAJECTORY_TASK_NAME]
    
            _prepare_for_planning(client, (ROBOT_NAME,))
    
>           planned = client.plan_to_joint_targets(
                {
                    group_ids["left_manipulator"]: _offset_target(client, LEFT_SLICE, 0.02),
                    group_ids["right_manipulator"]: _offset_target(client, RIGHT_SLICE, -0.02),
                }
            )

client     = <dimos.core.rpc_client.RPCClient object at 0x76164eb0d880>
coordinator_client = <dimos.core.rpc_client.RPCClient object at 0x76164ca00860>
group_ids  = {'left_manipulator': 'openarm/left_manipulator', 'right_manipulator': 'openarm/right_manipulator'}
info       = {'base_link': 'openarm_body_link0', 'end_effector_link': None, 'has_joint_name_mapping': True, 'home_joints': [0.0, 0.0, 0.0, 0.0, 0.0, 0.0, ...], ...}
lcm_spy    = <dimos.e2e_tests.lcm_spy.LcmSpy object at 0x76164c99fc50>
start_blueprint = <function start_blueprint.<locals>.set_name_and_start at 0x76163d582e80>
tasks      = ['traj_arm']

dimos/e2e_tests/test_manipulation_planning_groups.py:211: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
dimos/core/rpc_client.py:93: in __call__
    result, unsub_fn = self._rpc.call_sync(
        args       = ({'openarm/left_manipulator': JointState(ts=1786163348.9394836, frame_id='', name=[], position=[0.02, 0.02, 0.02, 0.02...8.9399347, frame_id='', name=[], position=[-0.02, -0.02, -0.02, -0.02, -0.02, -0.02, -0.02], velocity=[], effort=[])},)
        kwargs     = {}
        self       = <dimos.core.rpc_client.RpcCall object at 0x7616a6c93410>
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <dimos.protocol.rpc.pubsubrpc.LCMRPC object at 0x76164eb0ccb0>
name = 'ManipulationModule/plan_to_joint_targets'
arguments = (({'openarm/left_manipulator': JointState(ts=1786163348.9394836, frame_id='', name=[], position=[0.02, 0.02, 0.02, 0.0...9347, frame_id='', name=[], position=[-0.02, -0.02, -0.02, -0.02, -0.02, -0.02, -0.02], velocity=[], effort=[])},), {})
rpc_timeout = 120.0

    def call_sync(
        self, name: str, arguments: Args, rpc_timeout: float | None = None
    ) -> tuple[Any, Callable[[], None]]:
        if rpc_timeout is None:
            method = name.rsplit("/", 1)[-1]
            rpc_timeout = self.rpc_timeouts.get(name) or self.rpc_timeouts.get(
                method, self.default_rpc_timeout
            )
        event = threading.Event()
    
        def receive_value(val) -> None:  # type: ignore[no-untyped-def]
            event.result = val  # type: ignore[attr-defined]  # attach to event
            event.set()
    
        unsub_fn = self.call(name, arguments, receive_value)
        if not event.wait(rpc_timeout):
            # Retries register new callbacks. Remove this expired callback so
            # repeated timeouts do not accumulate entries in the shared response map.
            unsub_fn()
            raise TimeoutError(f"RPC call to '{name}' timed out after {rpc_timeout} seconds")
    
        # Check if the result is an exception and raise it
        result = event.result  # type: ignore[attr-defined]
        if isinstance(result, BaseException):
>           raise result
E           RuntimeError: Invalid goal configuration requested, cannot plan!

arguments  = (({'openarm/left_manipulator': JointState(ts=1786163348.9394836, frame_id='', name=[], position=[0.02, 0.02, 0.02, 0.0...9347, frame_id='', name=[], position=[-0.02, -0.02, -0.02, -0.02, -0.02, -0.02, -0.02], velocity=[], effort=[])},), {})
event      = <threading.Event at 0x76164e5cfe30: set>
method     = 'plan_to_joint_targets'
name       = 'ManipulationModule/plan_to_joint_targets'
receive_value = <function RPCClient.call_sync.<locals>.receive_value at 0x76163d581da0>
result     = RuntimeError('Invalid goal configuration requested, cannot plan!')
rpc_timeout = 120.0
self       = <dimos.protocol.rpc.pubsubrpc.LCMRPC object at 0x76164eb0ccb0>
unsub_fn   = <function PubSubRPCMixin.call_cb.<locals>.unsubscribe_callback at 0x76163d583380>

.../protocol/rpc/spec.py:88: RuntimeError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

# Conflicts:
#	dimos/manipulation/test_roboplan.py
#	dimos/robot/manipulators/openarm/blueprints/teleop.py
#	docs/capabilities/manipulation/index.md
@github-actions github-actions Bot added the ready-to-merge Required CI checks have passed on this PR label Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Required CI checks have passed on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants