feat(teleop): add translation scaling - #3406
Open
ruthwikdasyam wants to merge 5 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #3406 +/- ##
=======================================
Coverage 76.09% 76.09%
=======================================
Files 1189 1190 +1
Lines 115284 115333 +49
Branches 10366 10368 +2
=======================================
+ Hits 87720 87766 +46
- Misses 24553 24556 +3
Partials 3011 3011
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
ruthwikdasyam
marked this pull request as ready for review
August 8, 2026 21:20
ruthwikdasyam
requested review from
Dreamsorcerer,
leshy,
mustafab0,
paul-nechifor and
spomichter
as code owners
August 8, 2026 21:20
Contributor
Author
|
@greptile you alive? |
Contributor
|
Yep, alive and well! Anything you'd like me to look into on this PR? |
Contributor
Author
@greptile review pls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution path
Problem
Quest controller position deltas and hosted arm keyboard velocity commands have no consistent, UI-adjustable motion ratio.
Closes DIM-1261
Solution
Add a finite, positive
translation_scaletoQuestTeleopConfig, defaulting to1.0, and apply it in the shared Quest pose-delta path. Add an opt-inenable_ui_scalinggate to the hosted arm command module. When enabled, the reliable state-plane command{"type":"teleop_scale","scale":<positive finite number>,"nonce":...}updates the active scale and returns acmd_ack.Hosted arms apply the scale to Quest position deltas and browser keyboard end-effector twists. Arm robot state reports
teleop_scale; disabled or invalid UI requests are rejected. Orientation is unchanged. Go2 remains unchanged.How to Test
uv run pytest dimos/teleop/hosted/test_arm_command.py dimos/teleop/hosted/test_go2_command.py dimos/teleop/quest/test_quest_teleop_module.pyAI assistance
OpenCode with gpt-5.6-terra implemented the change and tests; the author reviewed the implementation.
Checklist