chore(memory2): delete dead notes.md and empty test_e2e_processing.py - #3412
Open
spomichter wants to merge 1 commit into
Open
chore(memory2): delete dead notes.md and empty test_e2e_processing.py#3412spomichter wants to merge 1 commit into
spomichter wants to merge 1 commit into
Conversation
notes.md was 10 lines of scratch sketching a db()/db.stream API that never existed. test_e2e_processing.py contained only a license header — no code, no tests, collected by pytest for nothing.
spomichter
requested review from
Dreamsorcerer,
leshy,
mustafab0 and
paul-nechifor
as code owners
August 9, 2026 07:38
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #3412 +/- ##
=======================================
Coverage 76.09% 76.09%
=======================================
Files 1190 1190
Lines 115295 115295
Branches 10367 10367
=======================================
Hits 87729 87729
Misses 24554 24554
Partials 3012 3012
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
github-actions
Bot
added
the
ready-to-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two files in
dimos/memory2/that carry no information:notes.md— 10 lines of scratch sketching adb()/db.streamcontext-manager API that never existed. Nothing in the repo references it, and it describes neither the currentStore/Streamdesign nor a planned one.test_e2e_processing.py— a license header and nothing else. Zero code lines, zero tests. pytest collects it on every run for nothing.Kept everything else:
intro.md,architecture.md,streaming.md,embeddings.mdare accurate current docs (intro.mdhas md-babel executable blocks that CI runs), and thetool_*.pyfiles are deliberate run-on-demand tools that say so in their docstrings.pytest dimos/memory2→ 456 passed.