Repository navigation
chore(release): v1.2.4 — the stale upgrade marker no longer warns forever - #144
Merged
Merged
Conversation
Cuts the v1.2.4 patch release carrying the stale upgrade-marker fix (#141, merged in #142). The npm wrapper's `binaryVersion` moves in lockstep with the package version: it is the tag the postinstall script downloads from, so a mismatch would 404 every install. The CHANGELOG's [Unreleased] section becomes [1.2.4]; the release checklist's wrapper-verification steps now take the version as a variable so they don't need editing for every release. Refs #141
|
✔️ c0a3171 - Conventional commits check succeeded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cuts the v1.2.4 patch release, carrying the stale upgrade-marker fix merged in #142.
versionandbinaryVersionboth move to1.2.4.binaryVersionis the tag thepostinstallscript downloads from, so it must match the release tag exactly — a mismatch would 404 every install.[Unreleased]section becomes[1.2.4], with the compare links updated.README.md,CLAUDE.md,docs/managers.md, andSPEC.md.docs/release-checklist.md's wrapper-verification steps now take the version as a shell variable, so the next release doesn't need to edit them.What ships in this release
The user-facing fix from #142:
nodeup upgradethat arms a fresh marker can't have it deleted out from under it.nodeup packages cleanup --stale-sentinelclears a stale marker on demand, and refuses to clear one whose snapshot still exists.Test plan
make cigreen locally (0 lint issues; all packages pass under-race)go build ./...,go vet ./...,gofmt -l .cleanchecksums.txtchecksums.txtnpm view nodeupx version→1.2.4, and a realnpm install nodeupx@1.2.4yields an unquarantined binary that runschecksums.txt, no quarantine, runsCloses #141
🤖 Generated with puku-cli