Skip to content

fix: play stats modal too small on desktop screen #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keenthekeen merged 1 commit into from
Oct 11, 2026
Merged

fix: play stats modal too small on desktop screen #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/app/home/home.page.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,10 @@ p {
max-width: 36rem;
margin-inline: auto;

@media (min-width: 1024px) {
max-width: 50vw;
}

.play-stats-header {
display: flex;
flex-wrap: wrap;
Expand Down
1 change: 1 addition & 0 deletions src/app/home/home.page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ export class HomePage implements OnInit {
const modal = await this.modalCtrl.create({
component: ModalPlayStatsComponent,
componentProps: {stats: this.playStats},
cssClass: 'play-stats-modal',
});
await modal.present();
if (this.consentService.current === 'granted') {
Expand Down
2 changes: 1 addition & 1 deletion src/app/home/modal-play-stats.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ section:first-child h2 {
.hours {
margin-top: 0.5rem;
@include hour-grid;
max-width: 40rem;
max-width: 58rem;

.hour-label {
font-size: 0.7rem;
Expand Down
7 changes: 7 additions & 0 deletions src/global.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,13 @@ ion-list-header {
transform: translate(-50%, 0);
}

@media (min-width: 1024px) {
ion-modal.play-stats-modal {
--width: 80%;
--max-width: 60rem;
}
}

/* video.js adds .vjs-touch-enabled based on touch *capability* (navigator.maxTouchPoints), which
stays true on touchscreen laptops even when the mouse is the input in use. Gate on
(hover: none) and (pointer: coarse) too so these rules only kick in when touch is actually the
Expand Down
Loading