dind: remove zfs dependency - #586
Open
thaJeztah wants to merge 1 commit into
Open
Conversation
The zfs utilities were used by the zfs graph-driver. containerd provides an optional zfs-snapshotter, but it's not installed by default. Remove the dependency, as it's not used in the default configuration. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Contributor
Author
|
Size comparison; docker image ls dind
IMAGE ID DISK USAGE CONTENT SIZE EXTRA
dind:before 66a85fa1e49a 502MB 131MB
dind:ctr b42924822491 471MB 122MB |
Contributor
Author
|
Windows failure is unrelated; |
Contributor
Author
|
cc @tianon |
1 task
tianon
approved these changes
Sep 9, 2026
tianon
left a comment
tianon
left a comment
Member
There was a problem hiding this comment.
LGTM
I think we should give this a little time to "soak" in case there are users who notice and can justify the continued inclusion of ZFS, but I also think we'll probably find those most effectively by merging and releasing this, so I think we should do that sometime next week. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The zfs utilities were used by the zfs graph-driver. containerd provides an optional zfs-snapshotter, but it's not installed by default. Remove the dependency, as it's not used in the default configuration.