feat: add language prop - #71
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an optional language prop to the embed wrappers across frameworks (Vue, Svelte, Solid, React, Preact, Angular, and the Mitosis sources) and forwards it into the iframe options payload so the hosted embed can localize UI.
Changes:
- Add
language?: stringto each component’s public props type/interface. - Include
languagein the JSON options encoded into the iframe URL/hash for each embed variant (create/update/sign/multisign/direct).
Reviewed changes
Copilot reviewed 63 out of 63 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/vue/src/update-template.vue | Add language prop and forward into iframe options. |
| packages/vue/src/update-envelope.vue | Add language prop and forward into iframe options. |
| packages/vue/src/update-document.vue | Add language prop and forward into iframe options. |
| packages/vue/src/sign-document.vue | Add language prop and forward into iframe options. |
| packages/vue/src/multisign-document.vue | Add language prop and forward into iframe options. |
| packages/vue/src/direct-template.vue | Add language prop and forward into iframe options. |
| packages/vue/src/create-template.vue | Add language prop and forward into iframe options. |
| packages/vue/src/create-envelope.vue | Add language prop and forward into iframe options. |
| packages/vue/src/create-document.vue | Add language prop and forward into iframe options. |
| packages/svelte/src/update-template.svelte | Add language prop and forward into iframe options. |
| packages/svelte/src/update-envelope.svelte | Add language prop and forward into iframe options. |
| packages/svelte/src/update-document.svelte | Add language prop and forward into iframe options. |
| packages/svelte/src/sign-document.svelte | Add language prop and forward into iframe options. |
| packages/svelte/src/multisign-document.svelte | Add language prop and forward into iframe options. |
| packages/svelte/src/direct-template.svelte | Add language prop and forward into iframe options. |
| packages/svelte/src/create-template.svelte | Add language prop and forward into iframe options. |
| packages/svelte/src/create-envelope.svelte | Add language prop and forward into iframe options. |
| packages/svelte/src/create-document.svelte | Add language prop and forward into iframe options. |
| packages/solid/src/update-template.tsx | Add language prop and forward into iframe options. |
| packages/solid/src/update-envelope.tsx | Add language prop and forward into iframe options. |
| packages/solid/src/update-document.tsx | Add language prop and forward into iframe options. |
| packages/solid/src/sign-document.tsx | Add language prop and forward into iframe options. |
| packages/solid/src/multisign-document.tsx | Add language prop and forward into iframe options. |
| packages/solid/src/direct-template.tsx | Add language prop and forward into iframe options. |
| packages/solid/src/create-template.tsx | Add language prop and forward into iframe options. |
| packages/solid/src/create-envelope.tsx | Add language prop and forward into iframe options. |
| packages/solid/src/create-document.tsx | Add language prop and forward into iframe options. |
| packages/react/src/update-template.tsx | Add language prop and forward into iframe options. |
| packages/react/src/update-envelope.tsx | Add language prop and forward into iframe options. |
| packages/react/src/update-document.tsx | Add language prop and forward into iframe options. |
| packages/react/src/sign-document.tsx | Add language prop and forward into iframe options. |
| packages/react/src/multisign-document.tsx | Add language prop and forward into iframe options. |
| packages/react/src/direct-template.tsx | Add language prop and forward into iframe options. |
| packages/react/src/create-template.tsx | Add language prop and forward into iframe options. |
| packages/react/src/create-envelope.tsx | Add language prop and forward into iframe options. |
| packages/react/src/create-document.tsx | Add language prop and forward into iframe options. |
| packages/preact/src/update-template.tsx | Add language prop and forward into iframe options. |
| packages/preact/src/update-envelope.tsx | Add language prop and forward into iframe options. |
| packages/preact/src/update-document.tsx | Add language prop and forward into iframe options. |
| packages/preact/src/sign-document.tsx | Add language prop and forward into iframe options. |
| packages/preact/src/multisign-document.tsx | Add language prop and forward into iframe options. |
| packages/preact/src/direct-template.tsx | Add language prop and forward into iframe options. |
| packages/preact/src/create-template.tsx | Add language prop and forward into iframe options. |
| packages/preact/src/create-envelope.tsx | Add language prop and forward into iframe options. |
| packages/preact/src/create-document.tsx | Add language prop and forward into iframe options. |
| packages/mitosis/src/update-template.lite.tsx | Add language prop and forward into iframe options (source for generated wrappers). |
| packages/mitosis/src/update-envelope.lite.tsx | Add language prop and forward into iframe options (source for generated wrappers). |
| packages/mitosis/src/update-document.lite.tsx | Add language prop and forward into iframe options (source for generated wrappers). |
| packages/mitosis/src/sign-document.lite.tsx | Add language prop and forward into iframe options (source for generated wrappers). |
| packages/mitosis/src/multisign-document.lite.tsx | Add language prop and forward into iframe options (source for generated wrappers). |
| packages/mitosis/src/direct-template.lite.tsx | Add language prop and forward into iframe options (source for generated wrappers). |
| packages/mitosis/src/create-template.lite.tsx | Add language prop and forward into iframe options (source for generated wrappers). |
| packages/mitosis/src/create-envelope.lite.tsx | Add language prop and forward into iframe options (source for generated wrappers). |
| packages/mitosis/src/create-document.lite.tsx | Add language prop and forward into iframe options (source for generated wrappers). |
| packages/angular/src/update-template.ts | Add language input and forward into iframe options. |
| packages/angular/src/update-envelope.ts | Add language input and forward into iframe options. |
| packages/angular/src/update-document.ts | Add language input and forward into iframe options. |
| packages/angular/src/sign-document.ts | Add language input and forward into iframe options. |
| packages/angular/src/multisign-document.ts | Add language input and forward into iframe options. |
| packages/angular/src/direct-template.ts | Add language input and forward into iframe options. |
| packages/angular/src/create-template.ts | Add language input and forward into iframe options. |
| packages/angular/src/create-envelope.ts | Add language input and forward into iframe options. |
| packages/angular/src/create-document.ts | Add language input and forward into iframe options. |
Comments suppressed due to low confidence (2)
packages/angular/src/update-envelope.ts:19
- The
biome-ignore lint/suspicious/noExplicitAnysuppression comment is now attached tolanguage, but the explicitanyis infeatures(Record<string, any>). This will likely re-enable the Biome lint error forfeatures. Move the suppression so it applies to thefeaturesline (or replaceRecord<string, any>withRecord<string, unknown>and drop the suppression), and consider using a more professional reason than "Hehe".
cssVars?: (CssVars & Record<string, string>) | undefined;
darkModeDisabled?: boolean | undefined;
language?: string | undefined; // biome-ignore lint/suspicious/noExplicitAny: Hehe
features?: DeepPartial<EnvelopeEditorSettings> & Record<string, any>;
onEnvelopeUpdated?: (data: {
externalId: string | null;
packages/angular/src/create-envelope.ts:20
- The
biome-ignore lint/suspicious/noExplicitAnysuppression comment is now attached tolanguage, but the explicitanyis infeatures(Record<string, any>). This will likely re-enable the Biome lint error forfeatures. Move the suppression so it applies to thefeaturesline (or replaceRecord<string, any>withRecord<string, unknown>and drop the suppression), and consider using a more professional reason than "Hehe".
cssVars?: (CssVars & Record<string, string>) | undefined;
darkModeDisabled?: boolean | undefined;
language?: string | undefined; // biome-ignore lint/suspicious/noExplicitAny: Hehe
features?: DeepPartial<EnvelopeEditorSettings> & Record<string, any>;
onEnvelopeCreated?: (data: {
externalId: string | null;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+20
to
24
| darkModeDisabled?: boolean | undefined; | ||
| language?: string | undefined; // biome-ignore lint/suspicious/noExplicitAny: Hehe | ||
|
|
||
| features?: DeepPartial<EnvelopeEditorSettings> & Record<string, any>; | ||
| onEnvelopeCreated?: (data: { |
Comment on lines
+13
to
17
| darkModeDisabled?: boolean | undefined; | ||
| language?: string | undefined; // biome-ignore lint/suspicious/noExplicitAny: Hehe | ||
|
|
||
| features?: DeepPartial<EnvelopeEditorSettings> & Record<string, any>; | ||
| onEnvelopeUpdated?: (data: { |
Comment on lines
+15
to
17
| language?: string | undefined; // biome-ignore lint/suspicious/noExplicitAny: Hehe | ||
|
|
||
| features?: DeepPartial<EnvelopeEditorSettings> & Record<string, any>; |
Comment on lines
+19
to
23
| darkModeDisabled?: boolean | undefined; | ||
| language?: string | undefined; // biome-ignore lint/suspicious/noExplicitAny: Hehe | ||
|
|
||
| features?: DeepPartial<EnvelopeEditorSettings> & Record<string, any>; | ||
| onEnvelopeUpdated?: (data: { |
Comment on lines
+14
to
16
| language?: string | undefined; // biome-ignore lint/suspicious/noExplicitAny: Hehe | ||
|
|
||
| features?: DeepPartial<EnvelopeEditorSettings> & Record<string, any>; |
Comment on lines
+15
to
17
| language?: string | undefined; // biome-ignore lint/suspicious/noExplicitAny: Hehe | ||
|
|
||
| features?: DeepPartial<EnvelopeEditorSettings> & Record<string, any>; |
Comment on lines
+11
to
15
| darkModeDisabled?: boolean | undefined; | ||
| language?: string | undefined; // biome-ignore lint/suspicious/noExplicitAny: Hehe | ||
|
|
||
| features?: DeepPartial<EnvelopeEditorSettings> & Record<string, any>; | ||
| onEnvelopeUpdated?: (data: { |
Comment on lines
11
to
16
| cssVars?: (CssVars & Record<string, string>) | undefined; | ||
| darkModeDisabled?: boolean | undefined; // biome-ignore lint/suspicious/noExplicitAny: Hehe | ||
| darkModeDisabled?: boolean | undefined; | ||
| language?: string | undefined; // biome-ignore lint/suspicious/noExplicitAny: Hehe | ||
|
|
||
| features?: DeepPartial<EnvelopeEditorSettings> & Record<string, any>; | ||
| onEnvelopeCreated?: (data: { |
Comment on lines
+10
to
14
| darkModeDisabled?: boolean | undefined; | ||
| language?: string | undefined; // biome-ignore lint/suspicious/noExplicitAny: Hehe | ||
|
|
||
| features?: DeepPartial<EnvelopeEditorSettings> & Record<string, any>; | ||
| onEnvelopeUpdated?: (data: { |
Comment on lines
10
to
15
| cssVars?: (CssVars & Record<string, string>) | undefined; | ||
| darkModeDisabled?: boolean | undefined; // biome-ignore lint/suspicious/noExplicitAny: Hehe | ||
| darkModeDisabled?: boolean | undefined; | ||
| language?: string | undefined; // biome-ignore lint/suspicious/noExplicitAny: Hehe | ||
|
|
||
| features?: DeepPartial<EnvelopeEditorSettings> & Record<string, any>; | ||
| onEnvelopeCreated?: (data: { |
Mythie
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.