Skip to content

Respect source updates on newly added target additions - #6891

Open
dkurepa wants to merge 1 commit into
dotnet:mainfrom
dkurepa:dkurepa/VersionDetailsAddtitionUpdatesBug
Open

dkurepa wants to merge 1 commit into
dotnet:mainfrom
dkurepa:dkurepa/VersionDetailsAddtitionUpdatesBug

Conversation

@dkurepa

@dkurepa dkurepa commented Nov 16, 2026

Copy link
Copy Markdown
Member

Copilot AI balanced review requested due to automatic review settings November 16, 2026 15:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain, though Codeflow tests were not run in this environment.

No open issues 🎉

What changed in this PR

Addresses #6890 by allowing source dependency updates to participate in version selection when the dependency was newly added on the target side.

Changes:

  • Uses the existing selector to resolve target additions against source updates.
  • Adds a regression test verifying that a newer source version produces an update rather than another addition.

Codeflow tests were not run in this review environment. Please run dotnet test test/Darc/Microsoft.DotNet.DarcLib.Codeflow.Tests.

File Description
test/​Darc/​Microsoft.DotNet.DarcLib.Tests/​VirtualMonoRepo/​VersionDetailsFileMergerTests.cs Tests that a newer source version overrides a target addition.
src/​Microsoft.DotNet.Darc/​DarcLib/​VirtualMonoRepo/​VmrVersionFileMerger.cs Applies version selection when a target addition overlaps a source update.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants