Repository navigation
Answer ReplicatedWithLeaderTerm to an empty AppendEntries after an entry of the sender's term - #311
Merged
sakno merged 3 commits intoNov 2, 2026
Conversation
… the sender's term with ReplicatedWithLeaderTerm
… the sender's term, and of an older one
…lt by the AOT tests too (TestLogEntry isn't)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #309.
A follower answers an empty AppendEntries whose preceding entry is of the sender's term with
ReplicatedWithLeaderTerm: its log holds the leader's entries of its term up to there. The leader then counts the answer as committed, so a heartbeat round completes on a majority instead of waiting for every member, and a hanging member's queued rounds no longer hold the lease and writes.Test:
TcpTransportTests.EmptyAppendEntriesAfterEntrygives a follower a log whose last entry is of term 2 and sends it an empty AppendEntries after that entry: from a sender of term 2 the answer isReplicatedWithLeaderTerm(Replicatedwithout the fix), from a sender of term 3 stillReplicated.The cluster tests pass on Linux.