Ensure that op_Equality/Inequality can actually import as expected#130086
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the JIT hardware-intrinsic metadata so the Vector* op_Equality / op_Inequality intrinsics derive their SIMD base type from the first argument (instead of falling back to return type / owning type), which is required for correct import/lowering of these boolean-returning SIMD operators.
Changes:
- Add
HW_Flag_BaseTypeFromFirstArgtoVector128/256/512.op_EqualityandVector128/256/512.op_Inequalityon xarch. - Add
HW_Flag_BaseTypeFromFirstArgtoVector64/128.op_EqualityandVector64/128.op_Inequalityon arm64.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/jit/hwintrinsiclistxarch.h | Marks Vector128/256/512 equality/inequality operators as base-type-from-arg so import/lowering has the correct SIMD base type. |
| src/coreclr/jit/hwintrinsiclistarm64.h | Marks Vector64/128 equality/inequality operators as base-type-from-arg so import/lowering has the correct SIMD base type. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
Member
|
Probably closes #93174 |
EgorBo
approved these changes
Jul 1, 2026
Member
Author
windows arm64windows x64With throughput improvements up to We get some really big diffs like
Where the improvement is because the API no longer hits an unrolled loop and just emits the 1-2 instructions as expected |
Member
Author
|
/ba-g unrelated timeouts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lack of the flag was blocking correct handling of
op_Equalityandop_Inequalityfor certain generic contexts (typically involvingISimdVector) as it would attempt to resolve using the wrong class handle.This resolves #93174