Skip to content

Avoid slow parallel connect failures in SocketAsyncEventArgs test #132931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MihaZupan merged 1 commit into from
Aug 31, 2026
+3 −18
Merged

Avoid slow parallel connect failures in SocketAsyncEventArgs test #132931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 3 additions & 18 deletions src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketAsyncEventArgsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1129,27 +1129,12 @@ public void Connect_Parallel_Success()
[SkipOnPlatform(TestPlatforms.Wasi, "Wasi doesn't support DualMode")]
public void Connect_Parallel_Fails()
{
using PortBlocker portBlocker = new PortBlocker(() =>
{
Socket socket = new Socket(AddressFamily.InterNetworkV6, SocketType.Stream, ProtocolType.Tcp);
socket.DualMode = false;
socket.BindToAnonymousPort(IPAddress.IPv6Loopback);
return socket;
});
Socket a = portBlocker.MainSocket;
// the port blocker did not call Socket.Bind so we called bind() but we did not update properties on Socket
Socket b = new Socket(portBlocker.SecondarySocket.SafeHandle);

// do NOT a.Listen(1);
// do NOT b.Listen(1);
// Do NOT a.AcceptAsync();
// Do NOT b.AcceptAsync();

var mres = new ManualResetEventSlim();
SocketAsyncEventArgs saea = new SocketAsyncEventArgs();
saea.RemoteEndPoint = new DnsEndPoint("localhost", portBlocker.Port);
// A bound but non-listening port can time out instead of refusing connections on macOS.
saea.RemoteEndPoint = new DnsEndPoint("localhost", DualModeBase.UnusedPort);
saea.Completed += (_, _) => mres.Set();
Comment thread
MihaZupan marked this conversation as resolved.
if (Socket.ConnectAsync(a.SocketType, a.ProtocolType, saea, ConnectAlgorithm.Parallel))
if (Socket.ConnectAsync(SocketType.Stream, ProtocolType.Tcp, saea, ConnectAlgorithm.Parallel))
{
Assert.True(mres.Wait(TestSettings.PassingTestLongTimeout), "Completed did not get called in time");
}
Expand Down
Loading