Allow constrained. call and ldftn for static virtual interface methods in ILVerify - #132944
Open
pkuyo wants to merge 2 commits into
Open
Allow constrained. call and ldftn for static virtual interface methods in ILVerify#132944pkuyo wants to merge 2 commits into
pkuyo wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
area-Tools-ILVerification
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
pkuyo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #132820
ILVerify predates static virtual interface methods, so the IL Roslyn emits for
T.M()(constrained. !!Tfollowed bycall) gets flagged with bogusConstrainedandCallAbstracterrors.Consume the
constrained.prefix oncallwhen the target is a static virtual method on an interface, and check that the constrained type actually implements that interface (newConstrainedTypeNoInterfaceImplerror).Tests added to PrefixTests.il.