Delete flaky GcRestrictedCalloutReversePInvoke test - #132958
Merged
MichalStrehovsky merged 4 commits intoAug 31, 2026
Merged
Conversation
|
Azure Pipelines: 16 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
…Invoke test Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @dotnet/interop-contrib |
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Make GcRestrictedCalloutReversePInvoke reliable on Linux ARM32
Fix flaky background Gen2 GC detection in GcRestrictedCalloutReversePInvoke test
Aug 31, 2026
Member
|
@copilot let's just delete the test instead. |
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Contributor
Author
Done in 6d5801e... wait, in the latest commit — removed the test entirely ( |
jkotas
approved these changes
Aug 31, 2026
MichalStrehovsky
changed the title
MichalStrehovsky
marked this pull request as ready for review
August 31, 2026 22:15
MichalStrehovsky
deleted the
copilot/make-gc-restricted-callout-reliable
branch
August 31, 2026 22:16
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Pull request overview
This PR removes the GcRestrictedCalloutReversePInvoke COM/ComWrappers test project from src/tests, eliminating a known flaky/time-sensitive test that can fail by timing out while waiting for a concurrent Gen2 GC.
Changes:
- Delete the
GcRestrictedCalloutReversePInvoketest implementation (Program.cs). - Remove the corresponding test project file (
GcRestrictedCalloutReversePInvoke.csproj). - Verified there are no remaining references to
GcRestrictedCalloutReversePInvokein the repo after the deletion (no build-time dangling references found via search).
File summaries
| File | Description |
|---|---|
| src/tests/Interop/COM/ComWrappers/GcRestrictedCalloutReversePInvoke/Program.cs | Removes the entire test logic that attempted to force/observe concurrent Gen2 GC under tracker callbacks. |
| src/tests/Interop/COM/ComWrappers/GcRestrictedCalloutReversePInvoke/GcRestrictedCalloutReversePInvoke.csproj | Removes the test project definition so the test is no longer built/executed. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #132939.
I wasn't sure if we want the test in the first place (#130459 (comment)) and now that it's known to be flaky, the decision is obvious.