feat(sandboxer): pluggable runtime provisioner across all providers - #149
Merged
Conversation
dungdm93
force-pushed
the
sandboxer-provision
branch
5 times, most recently
from
September 10, 2026 08:06
2328d28 to
8888040
Compare
…generic contracts
… and LIFO termination
dungdm93
force-pushed
the
sandboxer-provision
branch
from
September 10, 2026 08:51
8888040 to
a65bf6d
Compare
dungdm93
force-pushed
the
sandboxer-provision
branch
from
September 10, 2026 09:01
bccb780 to
7eb4943
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements pluggable runtime provisioning across all sandboxer providers (
container,incus, andhost) using a decorator-patternProvisioner[Req].Key Changes
provision.Provisioner[Req any]wrappingprovision.Launcher[Req any](func(ctx context.Context, req Req) (sandboxer.Sandbox, error)).Prepareacross all runtimes (parallel(pull -> mount)) with peer cancellation, sequentialPreLaunchrequest mutation, inner launcher execution, and sequentialPostLaunch.AddBindMount()injects bind mounts into*types.ContainerSpec; unwraps decorated sandbox to extractcontainerId.AddDiskDevice()injects disk devices into cloned*Template; unwraps decorated sandbox to extractDialer.Symlink[Req]()creates host directory symlinks duringPostLaunchand removes them on sandbox termination.sandboxer.Unwrap(sb)recursively unpacks nesteddecoratedSandboxinstances to retrieve the underlying concrete sandbox.runtime/provision,sandboxer,container,incus, andhost.CGO_ENABLED=0 go test -tags containers_image_openpgp ./....