Repository navigation
lib: enforce impl coherence and give SO symbols an owner - #220
Merged
Merged
Conversation
- check_impl_coherence: an impl is orphan when both the interface and the type are declared by another library; a duplicate (interface, type) pair is a conflicting impl. Same-library impls and local-type/foreign-interface impls remain valid. - SO extension symbols materialized from an index file now take the importing unit library as owner and are marked pub, instead of owner=-1/globally visible. Tests cover orphan and duplicate impls. selfhost/bootstrap/check green; canary 5/5 unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
impl 孤儿/重复检查；SO 索引符号归属导入库。