Repository navigation
Bump database-connector for the pushdown of TIMESTAMPTZ constants and conjunctions, and test both - #611
Closed
PeterVanHolland wants to merge 1 commit into
Closed
Bump database-connector for the pushdown of TIMESTAMPTZ constants and conjunctions, and test both#611PeterVanHolland wants to merge 1 commit into
PeterVanHolland wants to merge 1 commit into
Conversation
… conjunctions, and test both
Member
|
Closing as superseded by #615 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter pushdown is on by default, but some filters returned wrong rows. In an
America/New_Yorksession,ts < TIMESTAMPTZ '2024-01-01 11:30:00+00'included rows at2024-01-01 12:00:00+00. On an ENUM column,m = 'happy' OR m IS NULLreturned only the NULL row. We found these while working on DuckLake, which disables pushdown for its Postgres metadata catalog because of these bugs.Both bugs came from
database-connector, which writes pushed filters. It omitted offsets from TIMESTAMPTZ constants, so Postgres interpreted them in its session time zone. It also dropped conjunction children it could not write, such as ENUM comparisons, narrowing an OR.This bumps
database-connectorto the fix in duckdb/database-connector#46 and adds two sqllogictests covering New York TIMESTAMPTZ comparisons, includinginfinity, and OR filters with ENUM comparisons. AnEXPLAINcheck confirms that supported OR filters still get pushed. Both tests fail before the bump and pass after. Other Postgres tests pass locally on Postgres 17 except two requiring the CI setup for server-side COPY and the database name. This remains a draft until duckdb/database-connector#46 merges and the submodule moves to the merged commit.Related: pdet/ducklake_internal#176