Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions pyhilo/device/climate.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,20 @@ def hvac_action(self) -> str:
"""
Gets the current HVAC action of the device.

For 24 V thermostats the action comes from currentState ("HEATING",
"COOLING", "OFF"). For baseboard thermostats it is derived from the
reported heating power.

Returns:
str: 'heating' if heating is active, 'idle' otherwise.
str: one of 'heating', 'cooling', or 'idle'.
"""
if self.is_low_voltage:

@nlz242 nlz242 Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ceinture et bretelles ici... on est deja dans un hvac_action, les chances qu'on ai une unité de clim qui n'est pas un thermostat 24v (is_low_voltage), pas mal nul.
C'est OK, mais probablement pas nécessaire.
Pas besoin de modifier, je ne fais que relever le point.

state = self.current_state
if state == "HEATING":
return "heating"
if state == "COOLING":
return "cooling"
return "idle"
attr = self.get_value("heating", 0)
return "heating" if attr > 0 else "idle"

Expand Down Expand Up @@ -170,11 +181,7 @@ def allowed_fan_modes(self) -> list[str]:

@property
def current_state(self) -> str | None:
"""Raw running state reported by a 24 V thermostat.

Exposed for consumers, but deliberately not mapped to hvac_action yet:
its vocabulary has not been observed in enough operating conditions.
"""
"""Raw running state reported by a 24 V thermostat ("HEATING", "COOLING", "OFF")."""
return self._optional_str("current_state")

@property
Expand Down
27 changes: 27 additions & 0 deletions tests/test_climate.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,33 @@ def _climate(**readings):
return device


class TestHvacAction:
@pytest.mark.parametrize(
"current_state, expected",
[
pytest.param("HEATING", "heating", id="heating"),
pytest.param("COOLING", "cooling", id="cooling"),
pytest.param("OFF", "idle", id="off-is-idle"),
pytest.param(None, "idle", id="unreported-is-idle"),
],
)
def test_low_voltage_maps_current_state(self, current_state, expected):
kwargs = {"Thermostat24VMode": "AUTO"}
if current_state is not None:
kwargs["CurrentState"] = current_state
assert _climate(**kwargs).hvac_action == expected

@pytest.mark.parametrize(
"heating, expected",
[
pytest.param(1, "heating", id="power-on-is-heating"),
pytest.param(0, "idle", id="power-off-is-idle"),
],
)
def test_baseboard_uses_heating_power(self, heating, expected):
assert _climate(Heating=heating).hvac_action == expected


class TestAsList:
def test_none_is_empty(self):
assert as_list(None) == []
Expand Down
Loading