Skip to content

fix(mac): match the popover to the revision 8 design - #66

Merged
tieubao merged 3 commits into
mainfrom
fix/popover-design-parity
Nov 15, 2026
Merged

tieubao merged 3 commits into
mainfrom
fix/popover-design-parity

Conversation

@tieubao

@tieubao tieubao commented Nov 15, 2026

Copy link
Copy Markdown
Member

Popover design parity with revision 8 (gaps a to f of the sub-goal).

Done:

  • Opaque window surface #eff0f3 / #2b2c31 on the popover root.
  • Search placeholder drawn in the tertiary ink (SwiftUI ignores prompt: color); keycap chip on ⌃⌥S.
  • Row menu anchored under the More button with the first item lit; the popover grows to hold it (its measured height had been zero, so the menu flipped up over the header).
  • Trailing age on each row, from an optional added day (spec wins over the design's "Nd left", which stays in the meta line); separator 12% to 9%.
  • DEBUG-only -ShareBarShotsRender hook plus parity-shots.sh and parity-sample.swift: input-free captures and sRGB samples beside the design renders.

Proof: docs/verification/popover-design-parity.md, parity images and samples in docs/verification/share-bar/popover-parity/. swift test 320 pass, mac/build.sh 0.0.0 and mac/compat-check.sh v0.9.0 exit 0. Every sample within 6 steps of the design except the placeholder (15 steps light, deliberate darker tertiary).

Not attempted: a capture of the real NSPopover over light and dark desktops (needs screen input); share state does not print added yet, so the age column is empty on live tenants until bin/share emits it.

@tieubao
tieubao merged commit 0b1cd9b into main Nov 15, 2026
5 checks passed
@tieubao
tieubao deleted the fix/popover-design-parity branch November 15, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant