Repository navigation
fix(mac): match the popover to the revision 8 design - #66
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Popover design parity with revision 8 (gaps a to f of the sub-goal).
Done:
#eff0f3/#2b2c31on the popover root.prompt:color); keycap chip on⌃⌥S.addedday (spec wins over the design's "Nd left", which stays in the meta line); separator 12% to 9%.-ShareBarShotsRenderhook plusparity-shots.shandparity-sample.swift: input-free captures and sRGB samples beside the design renders.Proof:
docs/verification/popover-design-parity.md, parity images and samples indocs/verification/share-bar/popover-parity/. swift test 320 pass,mac/build.sh 0.0.0andmac/compat-check.sh v0.9.0exit 0. Every sample within 6 steps of the design except the placeholder (15 steps light, deliberate darker tertiary).Not attempted: a capture of the real NSPopover over light and dark desktops (needs screen input);
share statedoes not printaddedyet, so the age column is empty on live tenants untilbin/shareemits it.