Skip to content

feat(mac): share bar settings window - #68

Merged
tieubao merged 6 commits into
mainfrom
feat/sharebar-settings
Nov 15, 2026
Merged

tieubao merged 6 commits into
mainfrom
feat/sharebar-settings

Conversation

@tieubao

@tieubao tieubao commented Nov 15, 2026

Copy link
Copy Markdown
Member

What

The Share Bar Settings window (SPEC-009 TASK-4b14 to 4b18): General, Tenants, Advanced (admin and minter key sources), the dialog sheets, tenant detail and the journaled add, cloud-storage and members flows. AppRouter.openSettings(tab:) and openAddSheet(kind:) open it. The Members tab shows for an admin; its body is the next sub-goal's.

Spec tasks done

TASK-4b14, 4b15, 4b16, 4b17, 4b18. Screens come from an in-app test hook (DEC-81, DEBUG builds only) and a fake CLI that refuses what the real CLI refuses; no input reached the desktop.

Proof

docs/verification/sharebar-settings.md (AC to test map, recorded run, review, rollback) and docs/verification/share-bar/settings-a/README.md (66 captures, headless design renders beside them, sRGB samples, deviations, Mobbin comparison).

Not attempted

  • The Members tab body and the All links window (SG-16).
  • General's five notification and after-sharing toggles write their defaults; the readers live in StatusItemController (SG-16).
  • A unit test of the Settings store's flow chaining; it is covered by the shots and the FlowRunner tests.
  • No deploy, no live Cloudflare call.

@tieubao
tieubao merged commit 05c52be into main Nov 15, 2026
5 checks passed
@tieubao
tieubao deleted the feat/sharebar-settings branch November 15, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant