Repository navigation
feat(mac): popover drop-in, drag out, Quick Look and a global hotkey - #69
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Popover B for the Share Bar: drop-in publish with a progress row, drag out, Quick Look, and the Control-Option-S hotkey.
Spec tasks done: TASK-4b10, TASK-4b11, TASK-4b12, TASK-4b13 (SPEC-009). DEC-81 records the owner's rule that these screens are captured through in-app hooks and the fake CLI, with no live desktop input; the four AC lines are amended.
Proof:
docs/verification/sharebar-popover-b.md. 336 swift tests,mac/build.sh 0.0.0andmac/compat-check.sh v0.9.0pass. The hotkey negative control has a recorded red and green run. Ten scenes are captured in light and dark underdocs/verification/share-bar/popover-b/; all 18 design-parity runs sit within tolerance, with deviations listed in that folder's README and a Mobbin comparison.Shared files touched (additive):
MutationQueue.rungained optionalenvironmentandonOutput;DropViewgained enter and exit callbacks. The frozen files (Package.swift,AppDelegate,shots.sh, the fake CLI, the SG-06 Core files) are untouched.Not attempted: a real Finder drag, a real hotkey press from another app, a real Space on a focused row, and the TextEdit paste screen (no live input). General's Shortcut line for an in-use hotkey is exposed as
PopoverStore.hotkeyStatus.message; SG-10 renders it.