Skip to content

fix(share): close the spec gaps the state-machine audit trace found - #74

Merged
tieubao merged 5 commits into
mainfrom
fix/audit-spec-gaps
Nov 15, 2026
Merged

tieubao merged 5 commits into
mainfrom
fix/audit-spec-gaps

Conversation

@tieubao

@tieubao tieubao commented Nov 15, 2026

Copy link
Copy Markdown
Member

Closes the open gaps of the state-machine audit trace (docs/research/2026-11-14-audit-to-spec-trace.md, status section added).

Spec tasks done

  • Gap 2: add --cloud and every r2 add die op_interrupted while a dead setup-r2 journal sits at step 11 or 12; next is the journal's rerun line (SPEC-010 G2b, DEC-37, row JN-16).
  • Gap 6: an add whose upload, record PUT or pointer PUT answers 401 or 403 stores token.verify invalid, so state reads token.status invalid (G10, DEC-39, row TK-07).
  • Gap 7: join step 2 is four journaled writes, op_steps_join has nine rows, and only a cut from the record step on resumes; an earlier cut refuses invite_unavailable (SPEC-009 DEC-81, rows DP-join-1a to 1d and the renumbered rows).
  • Gap 3 leg: the bare prune verb runs access_ls_check last, from an exported token only (G7, DEC-38, row LS-06). Serve's hourly prune resolves no token, so the check is only as fresh as the last interactive run.

Proof

docs/verification/audit-spec-gaps.md: each new row red on the old code and green on the new; the full suite ran once under /bin/bash 3.2 (1842 checks, up from 1826; one environment check failed on idlers left by a run of mine that I killed, and passed on rerun).

Not attempted

  • A Share Bar change for join journals below step 6 (the Resume button); the spec says the callout asks for a new invite, and the Swift side is not built yet.
  • A Keychain cleanup for the keys a refused join cut leaves; a bare join has no config, so no host to forget them by.

A cloud add now refuses with op_interrupted while a dead setup-r2 sits at its config or marker step, and its next is the rerun line. An add that fails with 401 or 403 stores the rejected publisher token in .health. The prune verb stores the Access gate check beside ls. Join's old step 2 is four journaled writes (unseal, publisher key, connector key, config), and only a cut from the record step on resumes; an earlier cut refuses invite_unavailable.
@tieubao
tieubao force-pushed the fix/audit-spec-gaps branch from 5bc99bd to d8df398 Compare November 15, 2026 11:41
@tieubao
tieubao merged commit a62f7ff into main Nov 15, 2026
8 checks passed
@tieubao
tieubao deleted the fix/audit-spec-gaps branch November 15, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant