Repository navigation
feat(share): member adopt, min_cli enforcement and live member shares - #77
Merged
Merged
Conversation
member adopt registers an R5 publisher's own bucket-scoped token as an active cloud member (renamed in place so rm and renew find it). Every bucket write below the tenant marker's min_cli dies cli_below_min; reads stay open, share.json stays writable, member rm, purge and leave are never held back, and setup --members resets a forged marker after a yes. A member's add <port> now publishes a live row: a live probe on Console Labs showed a Worker VPC binding carries a WebSocket upgrade and a streamed body, so the v:3 pointer takes the live opt and Worker 6 returns a fresh 101 for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Spec tasks done: member
adopt(3e), WebSocket through the binding (3f, pass branch) andmin_clienforcement (4a).share member adopt <name> --token-id <id> [--by <label>]registers an R5 publisher's own bucket-scoped token as an active cloud member. The token must be in the minter's list and scoped to this bucket plus Zone Read; it is renamed in place somember rm,renewandinvitefind it. New codeadopt_token_scope.min_clidiescli_below_min; reads stay open.share.jsonstays writable;member rm,purgeandleaveare never held back by a forged marker;setup --members --yesresets a marker above this share.add <port>publishes a live row (v:3 optslive). Worker 6 forwards the upgrade and answers a fresh 101; a live row keeps its app's own type under the sandbox.Proof
docs/verification/members-adopt-mincli.md: the runs, the negative controls (red and green) and the live probe record (four runs, cleaned up by name).Review
kit:advisorandkit:security-revieweron the diff. One high (a comma list of types skipped the sandbox), three major (the 101 carried the machine's headers, a whole-run guard bypass insetup --members, adopt of a token another member holds) and the minors are fixed; notes P62.Not attempted
tests/worker.mjsis outside this sub-goal's Touches; the Worker source changed there, so its rows and a--wsharness option are in this PR.