Add method for removing redundant nodes#571
Open
arcondello wants to merge 28 commits into
Open
Conversation
arcondello
force-pushed
the
feature/node-equality-and-successor-transfer
branch
2 times, most recently
from
June 24, 2026 18:09
4dab596 to
a8040b8
Compare
arcondello
force-pushed
the
feature/node-equality-and-successor-transfer
branch
from
June 24, 2026 18:14
a8040b8 to
82cc356
Compare
arcondello
force-pushed
the
feature/node-equality-and-successor-transfer
branch
from
June 24, 2026 18:18
56195c1 to
57638a8
Compare
In C++20 Node::operator==(const Node&) const is amibiguous because either order is valid.
arcondello
force-pushed
the
feature/node-equality-and-successor-transfer
branch
from
July 2, 2026 17:35
39fb39d to
055fe62
Compare
arcondello
force-pushed
the
feature/node-equality-and-successor-transfer
branch
from
July 3, 2026 17:05
ee71c02 to
770a9cb
Compare
This requires some fiddling, see https://isocpp.org/wiki/faq/templates#nondependent-name-lookup-members for the why.
arcondello
commented
Jul 3, 2026
arcondello
force-pushed
the
feature/node-equality-and-successor-transfer
branch
from
July 3, 2026 18:09
261d2d6 to
98e4bd0
Compare
arcondello
force-pushed
the
feature/node-equality-and-successor-transfer
branch
from
July 3, 2026 18:14
98e4bd0 to
47e1be7
Compare
arcondello
force-pushed
the
feature/node-equality-and-successor-transfer
branch
from
July 6, 2026 16:43
90386b6 to
cd107a0
Compare
arcondello
commented
Jul 6, 2026
arcondello
force-pushed
the
feature/node-equality-and-successor-transfer
branch
from
July 8, 2026 17:33
42a0edd to
f7a75d1
Compare
arcondello
commented
Jul 9, 2026
arcondello
force-pushed
the
feature/node-equality-and-successor-transfer
branch
from
July 9, 2026 22:40
4e887e4 to
f643bca
Compare
arcondello
marked this pull request as ready for review
July 10, 2026 17:45
Member
Author
|
As a note: I didn't try to be inclusive about the |
arcondello
commented
Jul 10, 2026
arcondello
force-pushed
the
feature/node-equality-and-successor-transfer
branch
from
July 10, 2026 19:05
212caf4 to
d0dd3d3
Compare
fastbodin
reviewed
Jul 13, 2026
fastbodin
left a comment
fastbodin
left a comment
Collaborator
There was a problem hiding this comment.
Managed to work through all files excluding the test files. Thought I would upload these comments before moving onto them.
arcondello
commented
Jul 14, 2026
fastbodin
reviewed
Jul 14, 2026
fastbodin
left a comment
fastbodin
left a comment
Collaborator
There was a problem hiding this comment.
I have now gone through all the files. I would like to go through graph.cpp again.
The patience you had when writing these tests is a marvel.
arcondello
force-pushed
the
feature/node-equality-and-successor-transfer
branch
from
July 19, 2026 18:32
9f8d77e to
dde96ff
Compare
fastbodin
reviewed
Jul 21, 2026
| Symbols are redundant if they are the same type, they share the | ||
| same predecessors, and they encode the same operation. | ||
|
|
||
| If a symbol will not be removed if it has :class:`ArraySymbol` object(s) |
Collaborator
There was a problem hiding this comment.
I believe If is not necessary.
fastbodin
approved these changes
Jul 21, 2026
fastbodin
left a comment
fastbodin
left a comment
Collaborator
There was a problem hiding this comment.
Baring the above typo, LGTM! 🥳 . It took me a minute because I wanted to go over graph.cpp again in some detail. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #563
AI Generation Disclosure
No AI used.