Implement state checkpointing for CollectionNode#587
Draft
arcondello wants to merge 8 commits into
Draft
Conversation
arcondello
force-pushed
the
feature/decision-checkpoints
branch
from
July 17, 2026 23:25
6df7006 to
953304e
Compare
wbernoudy
reviewed
Jul 20, 2026
|
|
||
| CollectionCheckpoint_::CollectionCheckpoint_(CollectionStateData_* state_ptr) : | ||
| updates_(), | ||
| drop_(state_ptr->all_updates_.size()), // so we ignore any updates added before we're made |
Member
There was a problem hiding this comment.
What happens if some mutations are made to the node, then you make a checkpoint (causing the drop_ to be set > 0), and then you revert, make more mutations, and commit? Won't this cause some updates to be "dropped" that are actually relevant to the checkpoint?
Member
There was a problem hiding this comment.
Actually, I think I mean "make another checkpoint" as final step in the example rather than commit.
arcondello
force-pushed
the
feature/decision-checkpoints
branch
2 times, most recently
from
July 20, 2026 18:59
b4679c2 to
214c5e2
Compare
This avoids using GCC11 which had some bugs in their ranges implementation.
arcondello
force-pushed
the
feature/decision-checkpoints
branch
from
July 20, 2026 19:18
86b97e8 to
9cd035b
Compare
arcondello
commented
Jul 20, 2026
| virtual ~NodeStateCheckpoint() = default; | ||
|
|
||
| /// Whether the checkpoint is still available to be used. | ||
| virtual bool valid() const = 0; |
Member
Author
There was a problem hiding this comment.
This is unused and I should drop it.
arcondello
force-pushed
the
feature/decision-checkpoints
branch
2 times, most recently
from
July 21, 2026 21:20
f1aa563 to
06b9dc5
Compare
arcondello
force-pushed
the
feature/decision-checkpoints
branch
from
July 21, 2026 21:21
06b9dc5 to
f70699e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #510
Closes #552 by replacing it
AI Generation Disclosure
No AI was used to write the code. I intend to use it to review this PR.