Make State a class and add Graph::mutated()#589
Draft
wbernoudy wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
This PR adds the
Graph::mutated()method which returns the list of decision nodes with "pending" changes (see docstring for more details). It also makesStatea class rather than an alias to a vector of data pointers in order to help implementGraph::mutated().Additional information
For now, I left the implementation of
Graph::mutated()simple, and it will return only decision nodes, and not specific successors ofDisjointListsNodeandDisjointBitSetsNode. However, if we plan to use this directly withdescendants()/propagate()etc., we may need to consider returning specific successors because of the known performance hit on models with large amounts of lists/sets on individualDisjointListsNode/DisjointBitSetsNodes.AI Generation Disclosure
No AI tools used