Skip to content

Fix ament packaging#34

Open
artivis wants to merge 3 commits into
eProsima:mainfrom
artivis:fix/ament_packaging
Open

Fix ament packaging#34
artivis wants to merge 3 commits into
eProsima:mainfrom
artivis:fix/ament_packaging

Conversation

@artivis

@artivis artivis commented Jan 18, 2023

Copy link
Copy Markdown

Several packages provided by eProsima offer the possibility to be built with colcon. However said packages do not install their package.xml file nor do they populate the ament index.
This PR add two macros to cmake_utils to do just that. Plus they are invoked from the eprosima_packaging macro when a build with ament is detected.

Note that of course packages that aren't using this macro will not benefit from this quick fix, e.g. fastdds.

Related to ros-infrastructure/rosdep#724

Signed-off-by: artivis <jeremie.deray@canonical.com>
Signed-off-by: artivis <jeremie.deray@canonical.com>
Signed-off-by: artivis <jeremie.deray@canonical.com>
@artivis artivis temporarily deployed to codecov January 19, 2023 07:21 — with GitHub Actions Inactive
@artivis artivis temporarily deployed to codecov January 19, 2023 07:28 — with GitHub Actions Inactive
@codecov-commenter

codecov-commenter commented Jan 19, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.51%. Comparing base (932abda) to head (08a9144).
⚠️ Report is 99 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   71.18%   71.51%   +0.32%     
==========================================
  Files          49       50       +1     
  Lines         819      853      +34     
  Branches      187      202      +15     
==========================================
+ Hits          583      610      +27     
  Misses        134      134              
- Partials      102      109       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants