Skip to content

grass.gunittest: Gunittest other fixes #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
echoix wants to merge 6 commits into
base: main
Choose a base branch
from
Open

grass.gunittest: Gunittest other fixes #534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
660fe99
grass.gunittest: Always consider svn unavailable
echoix Aug 10, 2025
5c19b93
grass.script: Fix test_append_node_pid test using legalize_vector_name
echoix Aug 24, 2025
514f2ee
grass.gunittest: Specify encoding to files written in invoker.py
echoix Aug 17, 2025
47ec2fa
grass.gunittest: Specify encoding to files written in utils.py
echoix Aug 17, 2025
432b4de
grass.gunittest: Specify encoding to files written by GrassTestProgram
echoix Aug 17, 2025
fe19ce6
Merge branch 'main' into gunittest-other-fixes
echoix Nov 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions python/grass/gunittest/reporters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ def get_svn_revision():
:returns: SVN revision number as string or None if it is
not possible to get
"""
return None
# TODO: here should be starting directory
# but now we are using current as starting
with subprocess.Popen(
Expand All @@ -197,6 +198,7 @@ def get_svn_info():
:returns: SVN info as dictionary or None
if it is not possible to obtain it
"""
return None
try:
# TODO: introduce directory, not only current
with subprocess.Popen(
Expand Down Expand Up @@ -250,6 +252,7 @@ def get_svn_path_authors(path, from_date=None):

:returns: a set of authors
"""
return None
# "BASE:1" is the SVN default for local copies
revision_range = "BASE:1" if from_date is None else "BASE:{%s}" % from_date
try:
Expand Down
4 changes: 3 additions & 1 deletion python/grass/script/testsuite/test_names.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ def test_append_node_pid(self):
self.assertIn(base_name, full_name)
self.assertGreater(len(full_name), len(base_name))
self.assertIn(str(os.getpid()), full_name)
self.assertIn(utils.legalize_vector_name(platform.node()), full_name)
self.assertIn(
utils.legalize_vector_name(platform.node(), fallback_prefix=""), full_name
)
self.assertTrue(legal_name(full_name))
# TODO: It should be also a valid vector name
# but we don't have a function for that (same for all)
Expand Down
Loading