Repository navigation
Conversation
echoix
force-pushed
the
ruff-PTH113-os-path-isfile-and-others
branch
from
November 2, 2025 20:10
176f2bd to
0812cd1
Compare
echoix
force-pushed
the
ruff-PTH113-os-path-isfile-and-others
branch
from
November 2, 2025 20:48
25ca387 to
87dc9a7
Compare
Co-authored-by: Stefan Blumentrath <stefan.blumentrath@gmx.de>
Co-authored-by: Stefan Blumentrath <stefan.blumentrath@gmx.de>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
83
to
85
| self.assertTrue( | ||
| os.path.isdir(os.path.join(self.tmp_mapset_path, "signatures", "sig")) | ||
| Path(self.tmp_mapset_path, "signatures", "sig").is_dir() | ||
| ) |
There was a problem hiding this comment.
[ruff] reported by reviewdog 🐶
Suggested change
| self.assertTrue( | |
| os.path.isdir(os.path.join(self.tmp_mapset_path, "signatures", "sig")) | |
| Path(self.tmp_mapset_path, "signatures", "sig").is_dir() | |
| ) | |
| self.assertTrue(Path(self.tmp_mapset_path, "signatures", "sig").is_dir()) |
Comment on lines
88
to
90
| self.assertTrue( | ||
| os.path.isdir(os.path.join(self.tmp_mapset_path, "signatures", "sig")) | ||
| Path(self.tmp_mapset_path, "signatures", "sig").is_dir() | ||
| ) |
There was a problem hiding this comment.
[ruff] reported by reviewdog 🐶
Suggested change
| self.assertTrue( | |
| os.path.isdir(os.path.join(self.tmp_mapset_path, "signatures", "sig")) | |
| Path(self.tmp_mapset_path, "signatures", "sig").is_dir() | |
| ) | |
| self.assertTrue(Path(self.tmp_mapset_path, "signatures", "sig").is_dir()) |
Comment on lines
94
to
96
| self.assertTrue( | ||
| os.path.isdir(os.path.join(self.tmp_mapset_path, "signatures", "sigset")) | ||
| Path(self.tmp_mapset_path, "signatures", "sigset").is_dir() | ||
| ) |
There was a problem hiding this comment.
[ruff] reported by reviewdog 🐶
Suggested change
| self.assertTrue( | |
| os.path.isdir(os.path.join(self.tmp_mapset_path, "signatures", "sigset")) | |
| Path(self.tmp_mapset_path, "signatures", "sigset").is_dir() | |
| ) | |
| self.assertTrue(Path(self.tmp_mapset_path, "signatures", "sigset").is_dir()) |
Comment on lines
99
to
101
| self.assertTrue( | ||
| os.path.isdir(os.path.join(self.tmp_mapset_path, "signatures", "sigset")) | ||
| Path(self.tmp_mapset_path, "signatures", "sigset").is_dir() | ||
| ) |
There was a problem hiding this comment.
[ruff] reported by reviewdog 🐶
Suggested change
| self.assertTrue( | |
| os.path.isdir(os.path.join(self.tmp_mapset_path, "signatures", "sigset")) | |
| Path(self.tmp_mapset_path, "signatures", "sigset").is_dir() | |
| ) | |
| self.assertTrue(Path(self.tmp_mapset_path, "signatures", "sigset").is_dir()) |
Comment on lines
105
to
107
| self.assertTrue( | ||
| os.path.isdir(os.path.join(self.tmp_mapset_path, "signatures", "libsvm")) | ||
| Path(self.tmp_mapset_path, "signatures", "libsvm").is_dir() | ||
| ) |
There was a problem hiding this comment.
[ruff] reported by reviewdog 🐶
Suggested change
| self.assertTrue( | |
| os.path.isdir(os.path.join(self.tmp_mapset_path, "signatures", "libsvm")) | |
| Path(self.tmp_mapset_path, "signatures", "libsvm").is_dir() | |
| ) | |
| self.assertTrue(Path(self.tmp_mapset_path, "signatures", "libsvm").is_dir()) |
Comment on lines
110
to
112
| self.assertTrue( | ||
| os.path.isdir(os.path.join(self.tmp_mapset_path, "signatures", "libsvm")) | ||
| Path(self.tmp_mapset_path, "signatures", "libsvm").is_dir() | ||
| ) |
There was a problem hiding this comment.
[ruff] reported by reviewdog 🐶
Suggested change
| self.assertTrue( | |
| os.path.isdir(os.path.join(self.tmp_mapset_path, "signatures", "libsvm")) | |
| Path(self.tmp_mapset_path, "signatures", "libsvm").is_dir() | |
| ) | |
| self.assertTrue(Path(self.tmp_mapset_path, "signatures", "libsvm").is_dir()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruff rule: https://docs.astral.sh/ruff/rules/os-path-isfile/