Skip to content

Potential fix for code scanning alert no. 239: Incorrect return-value check for a 'scanf'-like function #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
echoix wants to merge 1 commit into from
Closed

Potential fix for code scanning alert no. 239: Incorrect return-value check for a 'scanf'-like function #663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions raster/r.to.rast3elev/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ int main(int argc, char *argv[])

/*Set the upper value */
if (param.upper->answer) {
if (sscanf(param.upper->answer, "%lf", &db.upper))
if (sscanf(param.upper->answer, "%lf", &db.upper) == 1)
db.useUpperVal = 2;
else
G_fatal_error(_("The upper value is not valid"));
Expand All @@ -419,7 +419,7 @@ int main(int argc, char *argv[])

/*Set the lower value */
if (param.lower->answer) {
if (sscanf(param.lower->answer, "%lf", &db.lower))
if (sscanf(param.lower->answer, "%lf", &db.lower) == 1)
db.useLowerVal = 2;
else
G_fatal_error(_("The lower value is not valid"));
Expand Down
Loading