Repository navigation
Conversation
echoix
changed the title
echoix
force-pushed
the
fix/xml-codespell-typos
branch
from
September 5, 2026 21:18
5563cdb to
9692743
Compare
Enable XML file type in codespell by removing it from exclude_types in .pre-commit-config.yaml. Fix all typos found in XML files: - gui/wxpython/xml/wxgui_items.xml: coordinate (1 occurrence) - gui/wxpython/core/testsuite/data/test_toolboxes_menudata_ref.xml: coordinate (2 occurrences) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
echoix
force-pushed
the
fix/xml-codespell-typos
branch
from
September 5, 2026 21:19
9692743 to
0bf72c2
Compare
Enabling codespell for XML also covers SVG (identify tags it as an XML type). gui/images/splash_screen.svg embeds a base64-encoded JPEG that codespell misreads as misspelled words (e.g. "nd", "Ot", "tHt"). Skip *.svg via codespell's own skip list so the exclusion also applies when codespell is run directly, not just through pre-commit.
echoix
added a commit
that referenced
this pull request
Sep 6, 2026
* xml: Fix codespell typos (co-ordinate → coordinate) Enable XML file type in codespell by removing it from exclude_types in .pre-commit-config.yaml. Fix all typos found in XML files: - gui/wxpython/xml/wxgui_items.xml: coordinate (1 occurrence) - gui/wxpython/core/testsuite/data/test_toolboxes_menudata_ref.xml: coordinate (2 occurrences) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> * codespell: Skip SVG files to avoid false positives Enabling codespell for XML also covers SVG (identify tags it as an XML type). gui/images/splash_screen.svg embeds a base64-encoded JPEG that codespell misreads as misspelled words (e.g. "nd", "Ot", "tHt"). Skip *.svg via codespell's own skip list so the exclusion also applies when codespell is run directly, not just through pre-commit. --------- Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables XML file type in codespell, fixes typos found in XML files, and skips SVG files (which codespell/identify treats as XML) to avoid false positives from embedded base64 image data.
Changes
xmlfromexclude_typesin.pre-commit-config.yaml.gui/wxpython/xml/wxgui_items.xml(1 occurrence)gui/wxpython/core/testsuite/data/test_toolboxes_menudata_ref.xml(2 occurrences)*.svgto codespell'sskiplist inpyproject.toml. SVG is tagged as an XML type byidentify, so enabling XML also unexcluded SVG;gui/images/splash_screen.svgembeds a base64 JPEG that codespell misread as typos (e.g. "nd", "Ot", "tHt"), which failed CI.Testing
pre-commit run codespell --all-filespasses locally.