Repository navigation
Conversation
) * Apply suggested fix to lib/raster3d/tilewrite.c from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * lib/raster3d: Add test for Rast3d_write_tile tile index bounds check Add a pytest test covering the tileIndex bounds check in Rast3d_write_tile: an index equal to nTiles must be rejected as out of range, and the last valid index must be accepted. The invalid call runs in a subprocess using the grass.lib.raster3d ctypes bindings because the rejection is a fatal error which exits the calling process. The out-of-range test fails without the bounds check change in this branch and passes with it. The test was written by Claude Code using the Claude Fable 5 model. --------- Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> Co-authored-by: Vaclav Petras <wenzeslaus@gmail.com>
echoix
pushed a commit
that referenced
this pull request
Sep 6, 2026
The NamedTemporaryFile fix for test_file was bundled into this PR together with unrelated Windows CI changes. Split it into its own PR (#694) so it can be reviewed and merged independently; revert it here to avoid landing it twice. This reverts commit cfcb92f. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HdSJkp8teAQ8W3dQKMRdz9
3 of 6 tasks
test_file kept a NamedTemporaryFile handle open while passing its path to r.kappa as the output file. Windows rejects a second process opening a file while the creating process still holds the handle; POSIX allows it. Use grass.script.core.tempfile() to get an unopened path instead, the same fix already applied to r.mfilter's testsuite in OSGeo#7878, and drop the now-unneeded @xfail_windows marker. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
echoix
force-pushed
the
claude/r-kappa-fix-separation-fjn5nx
branch
from
September 6, 2026 12:40
59eeb27 to
09cfcfc
Compare
echoix
added a commit
that referenced
this pull request
Sep 6, 2026
The NamedTemporaryFile fix for test_file was bundled into this PR together with unrelated Windows CI changes. Split it into its own PR (#694) so it can be reviewed and merged independently; revert it here to avoid landing it twice. This reverts commit 124fe83. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
6 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test_fileinraster/r.kappa/testsuite/test_r_kappa.pykept aNamedTemporaryFilehandle open while passing its path tor.kappaas theoutput file. Windows rejects a second process opening a file while the
creating process still holds the handle open; POSIX allows it. Use
grass.script.core.tempfile()to get an unopened path instead, the same fixalready applied to
r.mfilter's testsuite in OSGeo#7878, and drop thenow-unneeded
@xfail_windowsmarker.Motivation and context
Split out of #683, which bundled this fix together with unrelated Windows CI
changes (randomized test order infrastructure). This is a standalone,
independently mergeable fix.
How has this been tested?
Mirrors the already-merged, already-verified fix for the identical
anti-pattern in
r.mfilter(OSGeo#7878).Types of changes
Checklist
pre-defined prefixes
of this project.
🤖 Generated with Claude Code